From 57594c0600655f5211bccefc53b1b916cb83555f Mon Sep 17 00:00:00 2001 From: Ivan Pozdeev Date: Tue, 27 Feb 2024 18:49:47 +0300 Subject: [PATCH] More detailed explanation of the band-aid code --- plugins/python-build/scripts/add_miniforge.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/plugins/python-build/scripts/add_miniforge.py b/plugins/python-build/scripts/add_miniforge.py index 741ead90..bd2c91cf 100755 --- a/plugins/python-build/scripts/add_miniforge.py +++ b/plugins/python-build/scripts/add_miniforge.py @@ -100,8 +100,10 @@ for release in requests.get(f'https://api.github.com/repos/{MINIFORGE_REPO}/rele logger.info('Looking for %(version)s in %(out_dir)s', locals()) - # Release has no mambaforge artifacts, which causes the next check to always trigger - # Build scripts have already been generated, so safe to skip this version + # This release has no mambaforge artifacts which causes the next check to always trigger. + # Build scripts for miniforge3-4.13.0-0 have already been generated. + # Assuming this was a fluke, we don't yet need to implement proactively checking all releases for contents + # or ignoring a release if _any_ of the flavors is already present in Pyenv. if version == '4.13.0-0': continue