From 6820704c91afdd875e2a11bc647659c4d557aa5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mislav=20Marohni=C4=87?= Date: Thu, 29 Jan 2015 01:55:58 -0800 Subject: [PATCH] Remove warning about extraneous "ruby-" prefix in `.ruby-version` When we started to support reading `.ruby-version` files, we made a commitment to not support fuzzy version matching. Treating "ruby-2.1.5" as "2.1.5" is a sort of fuzzy matching, so we put in place a warning telling you to remove the extraneous "ruby-" prefix popularly used by other Ruby version managers to denote MRI. (Their logic is that MRI is "ruby" and other rubies are not "ruby", apparently.) However, people are often not able to remove the prefix in their projects because they want to support other coworkers and tools that sadly still require the prefix, like RubyMine. So to restore sanity for a big portion of our users, the warning is gone. --- libexec/rbenv-version-name | 3 --- test/version-name.bats | 6 +----- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/libexec/rbenv-version-name b/libexec/rbenv-version-name index 3eef70a8..3769a7cd 100755 --- a/libexec/rbenv-version-name +++ b/libexec/rbenv-version-name @@ -21,9 +21,6 @@ version_exists() { if version_exists "$RBENV_VERSION"; then echo "$RBENV_VERSION" elif version_exists "${RBENV_VERSION#ruby-}"; then - { echo "warning: ignoring extraneous \`ruby-' prefix in version \`${RBENV_VERSION}'" - echo " (set by $(rbenv-version-origin))" - } >&2 echo "${RBENV_VERSION#ruby-}" else echo "rbenv: version \`$RBENV_VERSION' is not installed" >&2 diff --git a/test/version-name.bats b/test/version-name.bats index 3f4d9b36..d6438b5b 100644 --- a/test/version-name.bats +++ b/test/version-name.bats @@ -57,9 +57,5 @@ setup() { cat > ".ruby-version" <<<"ruby-1.8.7" run rbenv-version-name assert_success - assert_output <