From 7fc5f46bbb843c6be95c3f87d19ba21fef25c5b8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mislav=20Marohnic=CC=81?= <mislav.marohnic@gmail.com>
Date: Sat, 6 Apr 2013 14:10:44 +0200
Subject: [PATCH] undo `assert_output_lines` in tests

It was a dumb idea and it wasn't even implemented perfectly.
---
 test/completions.bats |  8 +++++---
 test/exec.bats        | 36 ++++++++++++++++++++----------------
 test/hooks.bats       | 18 +++++++++++-------
 test/rehash.bats      | 10 ++++++----
 test/shell.bats       |  8 +++++---
 test/test_helper.bash | 24 +++++++-----------------
 test/whence.bats      |  8 +++++---
 test/which.bats       | 13 ++++++++-----
 8 files changed, 67 insertions(+), 58 deletions(-)

diff --git a/test/completions.bats b/test/completions.bats
index 0f79654d..0feccfa9 100644
--- a/test/completions.bats
+++ b/test/completions.bats
@@ -38,7 +38,9 @@ else
   exit 1
 fi"
   run rbenv-completions hello happy world
-  assert_success "\
-    happy
-    world"
+  assert_success
+  assert_output <<OUT
+happy
+world
+OUT
 }
diff --git a/test/exec.bats b/test/exec.bats
index 45e7f731..bf57c597 100644
--- a/test/exec.bats
+++ b/test/exec.bats
@@ -27,9 +27,11 @@ create_executable() {
 
   rbenv-rehash
   run rbenv-completions exec
-  assert_success "\
-    rake
-    ruby"
+  assert_success
+  assert_output <<OUT
+rake
+ruby
+OUT
 }
 
 @test "supports hook path with spaces" {
@@ -50,19 +52,20 @@ create_executable() {
 echo \$0
 for arg; do
   # hack to avoid bash builtin echo which can't output '-e'
-  printf "%s\\n" "\$arg"
+  printf "  %s\\n" "\$arg"
 done
 SH
 
-  run rbenv-exec ruby -w -e "puts 'hello world'" -- extra args
-  assert_success "\
-    ${RBENV_ROOT}/versions/2.0/bin/ruby
-    -w
-    -e
-    puts 'hello world'
-    --
-    extra
-    args"
+  run rbenv-exec ruby -w "/path to/ruby script.rb" -- extra args
+  assert_success
+  assert_output <<OUT
+${RBENV_ROOT}/versions/2.0/bin/ruby
+  -w
+  /path to/ruby script.rb
+  --
+  extra
+  args
+OUT
 }
 
 @test "supports ruby -S <cmd>" {
@@ -85,9 +88,10 @@ else
 fi
 SH
 
-  create_executable "rake" "\
-    #!/usr/bin/env ruby
-    echo hello rake"
+  create_executable "rake" <<SH
+#!/usr/bin/env ruby
+echo hello rake
+SH
 
   rbenv-rehash
   run ruby -S rake
diff --git a/test/hooks.bats b/test/hooks.bats
index 7d3b253f..0b53d430 100644
--- a/test/hooks.bats
+++ b/test/hooks.bats
@@ -22,10 +22,12 @@ create_hook() {
   create_hook "$path2" exec "bueno.bash"
 
   RBENV_HOOK_PATH="$path1:$path2" run rbenv-hooks exec
-  assert_success "\
-    ${RBENV_TEST_DIR}/rbenv.d/exec/ahoy.bash
-    ${RBENV_TEST_DIR}/rbenv.d/exec/hello.bash
-    ${RBENV_TEST_DIR}/etc/rbenv_hooks/exec/bueno.bash"
+  assert_success
+  assert_output <<OUT
+${RBENV_TEST_DIR}/rbenv.d/exec/ahoy.bash
+${RBENV_TEST_DIR}/rbenv.d/exec/hello.bash
+${RBENV_TEST_DIR}/etc/rbenv_hooks/exec/bueno.bash
+OUT
 }
 
 @test "supports hook paths with spaces" {
@@ -35,9 +37,11 @@ create_hook() {
   create_hook "$path2" exec "ahoy.bash"
 
   RBENV_HOOK_PATH="$path1:$path2" run rbenv-hooks exec
-  assert_success "\
-    ${RBENV_TEST_DIR}/my hooks/rbenv.d/exec/hello.bash
-    ${RBENV_TEST_DIR}/etc/rbenv hooks/exec/ahoy.bash"
+  assert_success
+  assert_output <<OUT
+${RBENV_TEST_DIR}/my hooks/rbenv.d/exec/hello.bash
+${RBENV_TEST_DIR}/etc/rbenv hooks/exec/ahoy.bash
+OUT
 }
 
 @test "resolves relative paths" {
diff --git a/test/rehash.bats b/test/rehash.bats
index 1e4d6d51..a9d23599 100755
--- a/test/rehash.bats
+++ b/test/rehash.bats
@@ -45,8 +45,10 @@ create_executable() {
   assert_success ""
 
   run ls "${RBENV_ROOT}/shims"
-  assert_success "\
-    rake
-    rspec
-    ruby"
+  assert_success
+  assert_output <<OUT
+rake
+rspec
+ruby
+OUT
 }
diff --git a/test/shell.bats b/test/shell.bats
index 1a5af662..579d31ae 100644
--- a/test/shell.bats
+++ b/test/shell.bats
@@ -22,9 +22,11 @@ load test_helper
 
 @test "shell change invalid version" {
   run rbenv-sh-shell 1.2.3
-  assert_failure "\
-    rbenv: version \`1.2.3' not installed
-    return 1"
+  assert_failure
+  assert_output <<SH
+rbenv: version \`1.2.3' not installed
+return 1
+SH
 }
 
 @test "shell change version" {
diff --git a/test/test_helper.bash b/test/test_helper.bash
index 1d49ab2a..75912f14 100644
--- a/test/test_helper.bash
+++ b/test/test_helper.bash
@@ -26,7 +26,7 @@ assert_success() {
   if [ "$status" -ne 0 ]; then
     flunk "command failed with exit status $status"
   elif [ "$#" -gt 0 ]; then
-    assert_output_lines "$1"
+    assert_output "$1"
   fi
 }
 
@@ -34,7 +34,7 @@ assert_failure() {
   if [ "$status" -eq 0 ]; then
     flunk "expected failed exit status"
   elif [ "$#" -gt 0 ]; then
-    assert_output_lines "$1"
+    assert_output "$1"
   fi
 }
 
@@ -47,21 +47,11 @@ assert_equal() {
 }
 
 assert_output() {
-  assert_equal "$1" "$output"
-}
-
-# compares lines with leading whitespace trimmed
-assert_output_lines() {
-  local -a expected
-  IFS=$'\n' expected=($1)
-  for (( i=0; i < ${#expected[@]}; i++ )); do
-    local wants="${expected[$i]}"
-    local got="${lines[$i]}"
-    assert_equal \
-      "${wants#"${wants%%[![:space:]]*}"}" \
-      "${got#"${got%%[![:space:]]*}"}"
-  done
-  assert_equal "${expected[$i]}" "${lines[$i]}"
+  local expected
+  if [ $# -eq 0 ]; then expected="$(cat -)"
+  else expected="$1"
+  fi
+  assert_equal "$expected" "$output"
 }
 
 assert_line() {
diff --git a/test/whence.bats b/test/whence.bats
index 583a2ca6..317f89e9 100644
--- a/test/whence.bats
+++ b/test/whence.bats
@@ -16,9 +16,11 @@ create_executable() {
   create_executable "2.0" "rspec"
 
   run rbenv-whence ruby
-  assert_success "\
-    1.8
-    2.0"
+  assert_success
+  assert_output <<OUT
+1.8
+2.0
+OUT
 
   run rbenv-whence rake
   assert_success "1.8"
diff --git a/test/which.bats b/test/which.bats
index 530c1f4b..cae53dd5 100644
--- a/test/which.bats
+++ b/test/which.bats
@@ -49,9 +49,12 @@ create_executable() {
   create_executable "2.0" "rspec"
 
   RBENV_VERSION=1.8 run rbenv-which rspec
-  assert_failure "\
-    rbenv: rspec: command not found
-    The \`rspec' command exists in these Ruby versions:
-      1.9
-      2.0"
+  assert_failure
+  assert_output <<OUT
+rbenv: rspec: command not found
+
+The \`rspec' command exists in these Ruby versions:
+  1.9
+  2.0
+OUT
 }