setop/pyenv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify version file read

Browse Source 
Avoid a subshell and external `cut` invocation, as well as a throwaway
intermediate array.
This commit is contained in:
Ville Skyttä 2022-03-08 20:58:58 +02:00
parent cec6d46792
commit b39d4291be
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libexec/rbenv-version-file-read
View File

@ -8,8 +8,7 @@ VERSION_FILE="$1"
if [ -s "$VERSION_FILE" ]; then if [ -s "$VERSION_FILE" ]; then
# Read the first word from the specified version file. Avoid reading it whole. # Read the first word from the specified version file. Avoid reading it whole.
IFS="${IFS}"$'\r' IFS="${IFS}"$'\r'
words=( $(cut -b 1-1024 "$VERSION_FILE") ) read -n 1024 -d "" -r version _ <"$VERSION_FILE" || :
version="${words[0]}"
if [ "$version" = ".." ] || [[ $version == */* ]]; then if [ "$version" = ".." ] || [[ $version == */* ]]; then
echo "rbenv: invalid version in \`$VERSION_FILE'" >&2 echo "rbenv: invalid version in \`$VERSION_FILE'" >&2