From 09a598883c26daf4c9ae8a4c855343a5f679cf6a Mon Sep 17 00:00:00 2001 From: Patrick Kanzler <4189642+patkan@users.noreply.github.com> Date: Fri, 28 Jul 2023 18:23:18 +0200 Subject: [PATCH] 351 ean example fix (#537) * bug/doc: Fix invalid EAN-13 barcode in examples In the various examples and python-escpos CLI there are a number of uses of `13243546557687` as an EAN-13 example. This EAN barcode is invalid as the checksum should be `0` and not `7`. ``` $ python test_print.py Traceback (most recent call last): File "test_print.py", line 5, in p.barcode('13243546557687', 'EAN13', 64, 2, '', '') File "/home/pi/fatt-display/lib/python3.7/site-packages/escpos/escpos.py", line 433, in barcode bc=bc, escpos.exceptions.BarcodeCodeError: No Barcode code was supplied (Barcode '13243546557687' not in a valid format for type 'EAN13') ``` This patch set removes `13243546557687` and replaces it with the valid number `40063813339310`. In researching the list of [assigned prefixes issued by G1][g1-prefixes] there seemed to be no "officially" defined test prefix, so this change was made to be minimally invasive using the number from the existing test cases. Resolves #350 Affects #176 [g1-prefixes]: https://www.gs1.org/standards/id-keys/company-prefix [test-code]: https://www.barcodelookup.com/4006381333931 --------- Co-authored-by: Brian 'Redbeard' Harrington --- AUTHORS | 1 + README.rst | 4 ++-- doc/user/usage.rst | 2 +- src/escpos/cli.py | 4 ++-- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/AUTHORS b/AUTHORS index 44f1ada..bb97913 100644 --- a/AUTHORS +++ b/AUTHORS @@ -8,6 +8,7 @@ Asuki Kono belono B. Howell Brian +Brian 'Redbeard' Harrington Christoph Heuel Cody (Quantified Code Bot) csoft2k diff --git a/README.rst b/README.rst index ce3dcb0..e873f1a 100644 --- a/README.rst +++ b/README.rst @@ -50,7 +50,7 @@ The basic usage is: p = Usb(0x04b8, 0x0202, 0, profile="TM-T88III") p.text("Hello World\n") p.image("logo.gif") - p.barcode('1324354657687', 'EAN13', 64, 2, '', '') + p.barcode('4006381333931', 'EAN13', 64, 2, '', '') p.cut() @@ -62,7 +62,7 @@ Another example based on the Network printer class: kitchen = Network("192.168.1.100") #Printer IP Address kitchen.text("Hello World\n") - kitchen.barcode('1324354657687', 'EAN13', 64, 2, '', '') + kitchen.barcode('4006381333931', 'EAN13', 64, 2, '', '') kitchen.cut() Another example based on the Serial printer class: diff --git a/doc/user/usage.rst b/doc/user/usage.rst index 9124c1b..8dec9ce 100644 --- a/doc/user/usage.rst +++ b/doc/user/usage.rst @@ -121,7 +121,7 @@ on a USB interface. # Print QR Code p.qr("You can readme from your smartphone") # Print barcode - p.barcode('1324354657687','EAN13',64,2,'','') + p.barcode('4006381333931','EAN13',64,2,'','') # Cut paper p.cut() diff --git a/src/escpos/cli.py b/src/escpos/cli.py index 6e692af..64eb077 100644 --- a/src/escpos/cli.py +++ b/src/escpos/cli.py @@ -52,7 +52,7 @@ DEMO_FUNCTIONS = { "barcodes_a": [ {"bc": "UPC-A", "code": "13243546576"}, {"bc": "UPC-E", "code": "132435"}, - {"bc": "EAN13", "code": "1324354657687"}, + {"bc": "EAN13", "code": "4006381333931"}, {"bc": "EAN8", "code": "1324354"}, {"bc": "CODE39", "code": "TEST"}, {"bc": "ITF", "code": "55867492279103"}, @@ -61,7 +61,7 @@ DEMO_FUNCTIONS = { "barcodes_b": [ {"bc": "UPC-A", "code": "13243546576", "function_type": "B"}, {"bc": "UPC-E", "code": "132435", "function_type": "B"}, - {"bc": "EAN13", "code": "1324354657687", "function_type": "B"}, + {"bc": "EAN13", "code": "4006381333931", "function_type": "B"}, {"bc": "EAN8", "code": "1324354", "function_type": "B"}, {"bc": "CODE39", "code": "TEST", "function_type": "B"}, {"bc": "ITF", "code": "55867492279103", "function_type": "B"},