From c40f2abe07f22dc71dfb3b323813019f91d9a033 Mon Sep 17 00:00:00 2001 From: Brian 'Redbeard' Harrington Date: Sat, 29 Jun 2019 18:35:49 -0700 Subject: [PATCH] bug/doc: Fix invalid EAN-13 barcode in examples In the various examples and python-escpos CLI there are a number of uses of `13243546557687` as an EAN-13 example. This EAN barcode is invalid as the checksum should be `0` and not `7`. ``` $ python test_print.py Traceback (most recent call last): File "test_print.py", line 5, in p.barcode('13243546557687', 'EAN13', 64, 2, '', '') File "/home/pi/fatt-display/lib/python3.7/site-packages/escpos/escpos.py", line 433, in barcode bc=bc, escpos.exceptions.BarcodeCodeError: No Barcode code was supplied (Barcode '13243546557687' not in a valid format for type 'EAN13') ``` This patch set removes `13243546557687` and replaces it with the valid number `40063813339310`. In researching the list of [assigned prefixes issued by G1][g1-prefixes] there seemed to be no "officially" defined test prefix, so this change was made to be minimally invasive using the number from the existing test cases. Resolves #350 Affects #176 [g1-prefixes]: https://www.gs1.org/standards/id-keys/company-prefix [test-code]: https://www.barcodelookup.com/4006381333931 --- README.rst | 4 ++-- doc/user/usage.rst | 2 +- src/escpos/cli.py | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/README.rst b/README.rst index 3eebf6d..af44db6 100644 --- a/README.rst +++ b/README.rst @@ -62,7 +62,7 @@ The basic usage is: p = Usb(0x04b8, 0x0202, 0, profile="TM-T88III") p.text("Hello World\n") p.image("logo.gif") - p.barcode('1324354657687', 'EAN13', 64, 2, '', '') + p.barcode('4006381333931', 'EAN13', 64, 2, '', '') p.cut() @@ -74,7 +74,7 @@ Another example based on the Network printer class: kitchen = Network("192.168.1.100") #Printer IP Address kitchen.text("Hello World\n") - kitchen.barcode('1324354657687', 'EAN13', 64, 2, '', '') + kitchen.barcode('4006381333931', 'EAN13', 64, 2, '', '') kitchen.cut() diff --git a/doc/user/usage.rst b/doc/user/usage.rst index 37f234a..ca8d260 100644 --- a/doc/user/usage.rst +++ b/doc/user/usage.rst @@ -119,7 +119,7 @@ on a USB interface. # Print QR Code p.qr("You can readme from your smartphone") # Print barcode - p.barcode('1324354657687','EAN13',64,2,'','') + p.barcode('4006381333931','EAN13',64,2,'','') # Cut paper p.cut() diff --git a/src/escpos/cli.py b/src/escpos/cli.py index 665e3b8..9cb0aab 100644 --- a/src/escpos/cli.py +++ b/src/escpos/cli.py @@ -53,7 +53,7 @@ DEMO_FUNCTIONS = { 'barcodes_a': [ {'bc': 'UPC-A', 'code': '13243546576'}, {'bc': 'UPC-E', 'code': '132435'}, - {'bc': 'EAN13', 'code': '1324354657687'}, + {'bc': 'EAN13', 'code': '4006381333931'}, {'bc': 'EAN8', 'code': '1324354'}, {'bc': 'CODE39', 'code': 'TEST'}, {'bc': 'ITF', 'code': '55867492279103'}, @@ -62,13 +62,13 @@ DEMO_FUNCTIONS = { 'barcodes_b': [ {'bc': 'UPC-A', 'code': '13243546576', 'function_type': 'B'}, {'bc': 'UPC-E', 'code': '132435', 'function_type': 'B'}, - {'bc': 'EAN13', 'code': '1324354657687', 'function_type': 'B'}, + {'bc': 'EAN13', 'code': '4006381333931', 'function_type': 'B'}, {'bc': 'EAN8', 'code': '1324354', 'function_type': 'B'}, {'bc': 'CODE39', 'code': 'TEST', 'function_type': 'B'}, {'bc': 'ITF', 'code': '55867492279103', 'function_type': 'B'}, {'bc': 'NW7', 'code': 'A00000000A', 'function_type': 'B'}, {'bc': 'CODE93', 'code': 'A00000000A', 'function_type': 'B'}, - {'bc': 'CODE93', 'code': '1324354657687', 'function_type': 'B'}, + {'bc': 'CODE93', 'code': '4006381333931', 'function_type': 'B'}, {'bc': 'CODE128A', 'code': 'TEST', 'function_type': 'B'}, {'bc': 'CODE128B', 'code': 'TEST', 'function_type': 'B'}, {'bc': 'CODE128C', 'code': 'TEST', 'function_type': 'B'},