setop/sqlite-parquet-vtable
1
0
Fork 0
mirror of https://github.com/cldellow/sqlite-parquet-vtable.git synced 2025-09-10 22:28:53 +00:00
Code Releases Activity

Add explicit test for file not found

Browse Source 
...caching the metadata moved where ParquetTable did I/O,
which introduced a segfault on not found
This commit is contained in:
Colin Dellow
2018-03-18 11:58:23 -04:00
parent 4cbde9fc09
commit 3b557f7fb0
3 changed files with 39 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
parquet/parquet.cc
View File

@@ -80,27 +80,26 @@ static int parquetConnect(
// Remove the delimiting single quotes
std::string fname = argv[3];
fname = fname.substr(1, fname.length() - 2);
std::unique_ptr<ParquetTable> table(new ParquetTable(fname));
std::unique_ptr<sqlite3_vtab_parquet, void(*)(void*)> vtab(
(sqlite3_vtab_parquet*)sqlite3_malloc(sizeof(sqlite3_vtab_parquet)),
sqlite3_free);
memset(vtab.get(), 0, sizeof(*vtab.get()));
try {
std::unique_ptr<ParquetTable> table(new ParquetTable(fname));
std::string create = table->CreateStatement();
int rc = sqlite3_declare_vtab(db, create.data());
if(rc)
return rc;
vtab->table = table.release();
*ppVtab = (sqlite3_vtab*)vtab.release();
return SQLITE_OK;
} catch (const std::exception& e) {
*pzErr = sqlite3_mprintf(e.what());
return SQLITE_ERROR;
}
vtab->table = table.release();
*ppVtab = (sqlite3_vtab*)vtab.release();
return SQLITE_OK;
}
/*