From d3128498b1c248d112affaa7a3aaeda85e38eb52 Mon Sep 17 00:00:00 2001
From: Colin Dellow <cldellow@gmail.com>
Date: Sun, 8 Jul 2018 10:37:18 -0400
Subject: [PATCH] Escape column names in CREATE

Fixes #33

Add test case with a hyphen and an embedded quotation mark
---
 parquet-generator/weird-column-names.parquet | Bin 0 -> 593 bytes
 parquet/parquet_table.cc                     |  11 ++++++++++-
 2 files changed, 10 insertions(+), 1 deletion(-)
 create mode 100644 parquet-generator/weird-column-names.parquet

diff --git a/parquet-generator/weird-column-names.parquet b/parquet-generator/weird-column-names.parquet
new file mode 100644
index 0000000000000000000000000000000000000000..af44ee28553fe0cfc27045a173acc937ab9e9496
GIT binary patch
literal 593
zcmWG=3^EjD5#<u)^ATkdWf5XvU=?6wU|=v5We^n-71IF;in58a$w)970+AR{ih)ys
z2}m+AGBPo!)yatRNSd-Rut`dAB<JTS<t65(iZY2YiRFovsTqkeh;hi6F=&AG0`*|C
z$q3UXBMC;JRy3O~F(IsCPs`8OO-d|++tkJcwCWBc*e;N69CjIF+GQ-kXpCXkDi(xY
z%s{)~_S|Cz+OvfjY!65$$Q~w1A5#Viw&LWB)Z9c-HU?21RVGAWr~*}h1Yk~v@j=D{
z*<wtRGLkkV2BR9OVWCEfhr}KM<Bvf@sUWeaur#$qH@Todp)9qiI5R&_!BEdc&rmnm
Z&oLm_!#_mQMuvd_f*9C=sU`rJm;k52Qk4Jz

literal 0
HcmV?d00001

diff --git a/parquet/parquet_table.cc b/parquet/parquet_table.cc
index a0ede14..d796b8a 100644
--- a/parquet/parquet_table.cc
+++ b/parquet/parquet_table.cc
@@ -52,7 +52,16 @@ std::string ParquetTable::CreateStatement() {
     if(i > 0)
       text += ", ";
 
-    text += col->name();
+    text += "\"";
+    // Horrifically inefficient, but easy to understand.
+    std::string colName = col->name();
+    for(char& c : colName) {
+      if(c == '"')
+        text += "\"\"";
+      else
+        text += c;
+    }
+    text += "\"";
 
     std::string type;