setop
/
python-escpos
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

351 ean example fix (#537) 

* bug/doc: Fix invalid EAN-13 barcode in examples

In the various examples and python-escpos CLI there are a number of uses
of `13243546557687` as an EAN-13 example.  This EAN barcode is invalid
as the checksum should be `0` and not `7`.

```
$ python test_print.py
Traceback (most recent call last):
  File "test_print.py", line 5, in <module>
    p.barcode('13243546557687', 'EAN13', 64, 2, '', '')
  File "/home/pi/fatt-display/lib/python3.7/site-packages/escpos/escpos.py", line 433, in barcode
    bc=bc,
escpos.exceptions.BarcodeCodeError: No Barcode code was supplied (Barcode '13243546557687' not in a valid format for type 'EAN13')
```

This patch set removes `13243546557687` and replaces it with the valid
number `40063813339310`.

In researching the list of [assigned prefixes issued by
G1][g1-prefixes] there seemed to be no "officially" defined test  prefix, so
this change was made to be minimally invasive using the number from the
existing test cases.

Resolves #350

Affects #176

[g1-prefixes]: https://www.gs1.org/standards/id-keys/company-prefix
[test-code]: https://www.barcodelookup.com/4006381333931

---------

Co-authored-by: Brian 'Redbeard' Harrington <redbeard@dead-city.org>
This commit is contained in:
Patrick Kanzler 2023-07-28 18:23:18 +02:00 committed by GitHub
parent df9e8ff394
commit 09a598883c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS
View File

@ -8,6 +8,7 @@ Asuki Kono
belono belono
B. Howell B. Howell
Brian Brian
Brian 'Redbeard' Harrington
Christoph Heuel Christoph Heuel
Cody (Quantified Code Bot) Cody (Quantified Code Bot)
csoft2k csoft2k

4
README.rst
View File

@ -50,7 +50,7 @@ The basic usage is:
p = Usb(0x04b8, 0x0202, 0, profile="TM-T88III") p = Usb(0x04b8, 0x0202, 0, profile="TM-T88III")
p.text("Hello World\n") p.text("Hello World\n")
p.image("logo.gif") p.image("logo.gif")
p.barcode('1324354657687', 'EAN13', 64, 2, '', '') p.barcode('4006381333931', 'EAN13', 64, 2, '', '')
p.cut() p.cut()
@ -62,7 +62,7 @@ Another example based on the Network printer class:
kitchen = Network("192.168.1.100") #Printer IP Address kitchen = Network("192.168.1.100") #Printer IP Address
kitchen.text("Hello World\n") kitchen.text("Hello World\n")
kitchen.barcode('1324354657687', 'EAN13', 64, 2, '', '') kitchen.barcode('4006381333931', 'EAN13', 64, 2, '', '')
kitchen.cut() kitchen.cut()
Another example based on the Serial printer class: Another example based on the Serial printer class:

2
doc/user/usage.rst
View File

@ -121,7 +121,7 @@ on a USB interface.
# Print QR Code # Print QR Code
p.qr("You can readme from your smartphone") p.qr("You can readme from your smartphone")
# Print barcode # Print barcode
p.barcode('1324354657687','EAN13',64,2,'','') p.barcode('4006381333931','EAN13',64,2,'','')
# Cut paper # Cut paper
p.cut() p.cut()

4
src/escpos/cli.py
View File

@ -52,7 +52,7 @@ DEMO_FUNCTIONS = {
"barcodes_a": [ "barcodes_a": [
{"bc": "UPC-A", "code": "13243546576"}, {"bc": "UPC-A", "code": "13243546576"},
{"bc": "UPC-E", "code": "132435"}, {"bc": "UPC-E", "code": "132435"},
{"bc": "EAN13", "code": "1324354657687"}, {"bc": "EAN13", "code": "4006381333931"},
{"bc": "EAN8", "code": "1324354"}, {"bc": "EAN8", "code": "1324354"},
{"bc": "CODE39", "code": "TEST"}, {"bc": "CODE39", "code": "TEST"},
{"bc": "ITF", "code": "55867492279103"}, {"bc": "ITF", "code": "55867492279103"},
@ -61,7 +61,7 @@ DEMO_FUNCTIONS = {
"barcodes_b": [ "barcodes_b": [
{"bc": "UPC-A", "code": "13243546576", "function_type": "B"}, {"bc": "UPC-A", "code": "13243546576", "function_type": "B"},
{"bc": "UPC-E", "code": "132435", "function_type": "B"}, {"bc": "UPC-E", "code": "132435", "function_type": "B"},
{"bc": "EAN13", "code": "1324354657687", "function_type": "B"}, {"bc": "EAN13", "code": "4006381333931", "function_type": "B"},
{"bc": "EAN8", "code": "1324354", "function_type": "B"}, {"bc": "EAN8", "code": "1324354", "function_type": "B"},
{"bc": "CODE39", "code": "TEST", "function_type": "B"}, {"bc": "CODE39", "code": "TEST", "function_type": "B"},
{"bc": "ITF", "code": "55867492279103", "function_type": "B"}, {"bc": "ITF", "code": "55867492279103", "function_type": "B"},