Make logging.basicConfig conditional (#670)

Co-authored-by: Patrick Kanzler <4189642+patkan@users.noreply.github.com>

.github/workflows/black.yml

@@ -6,7 +6,7 @@ jobs:
   black-code-style:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: psf/black@stable
         with:
           version: "23.12.0"

.github/workflows/codeql-analysis.yml

@@ -30,7 +30,7 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v4
+      uses: actions/checkout@v5
       with:
         # We must fetch at least the immediate parents so that if this is
         # a pull request then we can checkout the head.

.github/workflows/documentation.yml

@@ -19,7 +19,7 @@ jobs:
 
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           submodules: 'recursive'
       - name: Install packages

.github/workflows/pythonpackage-windows.yml

@@ -15,7 +15,7 @@ jobs:
         python-version: ['3.11', '3.12', '3.13']
 
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
       with:
         submodules: 'recursive'
     - name: Set up Python ${{ matrix.python-version }}

.github/workflows/pythonpackage.yml

@@ -18,7 +18,7 @@ jobs:
         python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
 
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
       with:
         submodules: 'recursive'
     - name: Set up Python ${{ matrix.python-version }}

examples/docker-flask/requirements.txt

@@ -1,4 +1,4 @@
-appdirs==1.4.4
+platformdirs==4.3.8
 argcomplete==3.0.8
 blinker==1.6.2
 click==8.1.3

setup.cfg

@@ -43,7 +43,7 @@ install_requires =
     python-barcode>=0.15.0,<1
     setuptools
     six
-    appdirs
+    platformdirs
     PyYAML
     argcomplete
     importlib_resources

src/escpos/capabilities.py

@@ -13,9 +13,10 @@ from typing import Any, Dict, Optional, Type
 import importlib_resources
 import yaml
 
-logging.basicConfig()
-logger = logging.getLogger(__name__)
+if environ.get("ESCPOS_CAPABILITIES_DEBUG", 0):
+    logging.basicConfig()
 
+logger = logging.getLogger(__name__)
 pickle_dir = environ.get("ESCPOS_CAPABILITIES_PICKLE_DIR", mkdtemp())
 pickle_path = path.join(pickle_dir, f"{platform.python_version()}.capabilities.pickle")
 # get a temporary file from importlib_resources if no file is specified in env

src/escpos/config.py

@@ -5,7 +5,7 @@ This module contains the implementations of abstract base class :py:class:`Confi
 import os
 import pathlib
 
-import appdirs
+import platformdirs
 import yaml
 
 from . import exceptions, printer
@@ -55,7 +55,7 @@ class Config:
 
         if not config_path:
             config_path = os.path.join(
-                appdirs.user_config_dir(self._app_name), self._config_file
+                platformdirs.user_config_dir(self._app_name), self._config_file
             )
         if isinstance(config_path, pathlib.Path):
             # store string if posixpath

test/test_config.py

@@ -8,7 +8,7 @@
 """
 import pathlib
 
-import appdirs
+import platformdirs
 import pytest
 
 import escpos.exceptions
@@ -80,7 +80,7 @@ def test_config_load_from_appdir() -> None:
 
     # generate a dummy config
     config_file = (
-        pathlib.Path(appdirs.user_config_dir(config.Config._app_name))
+        pathlib.Path(platformdirs.user_config_dir(config.Config._app_name))
         / config.Config._config_file
     )
 

tox.ini

@@ -55,7 +55,6 @@ deps = mypy
        types-six
        types-mock
        types-PyYAML
-       types-appdirs
        types-Pillow
        types-pyserial
        types-pywin32>=306.0.0.6