update mailmap-file

bug/doc: Fix invalid EAN-13 barcode in examples
In the various examples and python-escpos CLI there are a number of uses of `13243546557687` as an EAN-13 example. This EAN barcode is invalid as the checksum should be `0` and not `7`. ``` $ python test_print.py Traceback (most recent call last): File "test_print.py", line 5, in <module> p.barcode('13243546557687', 'EAN13', 64, 2, '', '') File "/home/pi/fatt-display/lib/python3.7/site-packages/escpos/escpos.py", line 433, in barcode bc=bc, escpos.exceptions.BarcodeCodeError: No Barcode code was supplied (Barcode '13243546557687' not in a valid format for type 'EAN13') ``` This patch set removes `13243546557687` and replaces it with the valid number `40063813339310`. In researching the list of [assigned prefixes issued by G1][g1-prefixes] there seemed to be no "officially" defined test prefix, so this change was made to be minimally invasive using the number from the existing test cases. Resolves #350 Affects #176 [g1-prefixes]: https://www.gs1.org/standards/id-keys/company-prefix [test-code]: https://www.barcodelookup.com/4006381333931
2025-09-13 09:09:58 +00:00 · 2019-06-30 17:43:20 +02:00 · 2019-06-29 19:19:16 -07:00 · 2019-06-29 19:19:16 -07:00 · 2019-06-19 15:50:19 +02:00 · 2019-06-19 15:28:46 +02:00
35 changed files with 712 additions and 176 deletions
--- a/.gitignore
+++ b/.gitignore
@@ -20,6 +20,7 @@ dist/
 .coverage
 src/escpos/version.py
 .hypothesis
+.pytest_cache/

 # testing temporary directories
 test/test-cli-output/
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,3 +1,4 @@
 [submodule "capabilities-data"]
 	path = capabilities-data
 	url = https://github.com/receipt-print-hq/escpos-printer-db.git
+	branch = master
--- a/.mailmap
+++ b/.mailmap
@@ -8,4 +8,9 @@ Cody (Quantified Code Bot) <cody@quantifiedcode.com> Cody <cody@quantifiedcode.c
 Renato Lorenzi <renato.lorenzi@senior.com.br>        Renato.Lorenzi <renato.lorenzi@senior.com.br>
 Ahmed Tahri <nyuubi.10@gmail.com>                    TAHRI Ahmed <nyuubi.10@gmail.com>
 Michael Elsdörfer <michael@elsdoerfer.com>           Michael Elsdörfer <michael@elsdoerfer.info>
-csoft2k <csoft2k@hotmail.com>
+Juanmi Taboada <juanmi@juanmitaboada.com>            Juanmi Taboada <juanmi@juanmitaboada.com>
+csoft2k <csoft2k@hotmail.com>
+Sergio Pulgarin <sergio.pulgarin@gmail.com>
+reck31 <rakesh.gunduka@gmail.com>
+Alex Debiasio <alex.debiasio@thinkin.io>             <alex.debiasio@studenti.unitn.it>
+Brian 'Redbeard' Harrington <redbeard@dead-city.org>
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,18 +1,36 @@
 language: python
 sudo: false
 cache: pip
+dist: xenial
 git:
  depth: 100000
 addons:
  apt:
    packages:
      - graphviz
+env:
+  global:
+    - ESCPOS_CAPABILITIES_FILE=/home/travis/build/python-escpos/python-escpos/capabilities-data/dist/capabilities.json
 matrix:
+  fast_finish: true
  include:
+    - name: "Python 3.7 on Windows"
+      os: windows
+      language: shell
+      before_install:
+         - choco install python
+         - pip install tox codecov 'sphinx>=1.5.1'
+      env:
+         - TOXENV=py37
+         - PATH=/c/Python37:/c/Python37/Scripts:$PATH
+         - ESCPOS_CAPABILITIES_FILE=C:/Users/travis/build/python-escpos/python-escpos/capabilities-data/dist/capabilities.json
+    - name: "Python 3.7 on macOS"
+      os: osx
+      osx_image: xcode10.2
+      language: shell
+      env: TOXENV=py37 ESCPOS_CAPABILITIES_FILE=/Users/travis/build/python-escpos/python-escpos/capabilities-data/dist/capabilities.json
    - python: 2.7
      env: TOXENV=py27
-    - python: 3.3
-      env: TOXENV=py33
    - python: 3.4
      env: TOXENV=py34
    - python: 3.5
@@ -21,22 +39,31 @@ matrix:
      env: TOXENV=py36
    - python: 3.6-dev
      env: TOXENV=py36
-    - python: nightly
+    - python: 3.7
      env: TOXENV=py37
+    - python: 3.7-dev
+      env: TOXENV=py37
+    - python: 3.8-dev
+      env: TOXENV=py38
+    - python: nightly
+      env: TOXENV=py38
    - python: pypy
      env: TOXENV=pypy
    - python: pypy3
      env: TOXENV=pypy3
-    - python: 2.7
+    - python: 3.7
      env: TOXENV=docs
-    - python: 2.7
-      env: TOXENV=flake8
-    - python: 3.6
+    - python: 3.7
      env: TOXENV=flake8
  allow_failures:
+    - python: 2.7
    - python: 3.6-dev
+    - python: 3.7-dev
+    - python: 3.8-dev
    - python: nightly
    - python: pypy3
+    - os: windows
+    - os: osx
 before_install:
    - pip install tox codecov 'sphinx>=1.5.1'
    - ./doc/generate_authors.sh --check
@@ -59,4 +86,4 @@ deploy:
      tags: true
      repo: python-escpos/python-escpos
      branch: master
-      condition: $TRAVIS_PYTHON_VERSION = "3.5"
+      condition: $TRAVIS_PYTHON_VERSION = "3.7"
--- a/12
+++ b/12
@@ -1,6 +1,9 @@
 Ahmed Tahri
+akeonly
+Alex Debiasio
 Asuki Kono
 belono
+Brian 'Redbeard' Harrington
 Christoph Heuel
 Cody (Quantified Code Bot)
 csoft2k
@@ -8,20 +11,29 @@ Curtis // mashedkeyboard
 Davis Goglin
 Dean Rispin
 Dmytro Katyukha
+Gerard Marull-Paretas
 Hark
 Joel Lehtonen
+Justin Vieira
+kennedy
 Kristi
 ldos
+Lucy Linder
 Manuel F Martinez
 Michael Billington
 Michael Elsdörfer
 mrwunderbar666
 Nathan Bookham
+Omer Akram
 Patrick Kanzler
+primax79
 Qian Linfeng
+Ramon Poca
+reck31
 Renato Lorenzi
 Romain Porte
 Sam Cheng
+Sergio Pulgarin
 Stephan Sokolow
 Thijs Triemstra
 Thomas van den Berg
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -1,6 +1,87 @@
 *********
 Changelog
 *********
+2019-06-19 - Version 3.0a6 - "Mistake not..."
+---------------------------------------------
+This release is the seventh alpha release of the new version 3.0.
+Please be aware the the API is subject to change until v3.0 is
+released.
+
+changes
+^^^^^^^
+- fix inclusion of the capabilities-file
+- execute CI jobs also on Windows and macOS-targets
+- improve documentation
+
+contributors
+^^^^^^^^^^^^
+- Patrick Kanzler
+
+2019-06-16 - Version 3.0a5 - "Lightly Seared On The Reality Grill"
+------------------------------------------------------------------
+This release is the sixth alpha release of the new version 3.0. Please
+be aware that the API is subject to change until v3.0 is released.
+
+changes
+^^^^^^^
+- allow arbitrary USB arguments in USB-class
+- add Win32Raw-Printer on Windows-platforms
+- add and improve Windows support of USB-class
+- use pyyaml safe_load()
+- improve doc
+- implement _read method of Network printer class
+
+contributors
+^^^^^^^^^^^^
+- Patrick Kanzler
+- Gerard Marull-Paretas
+- Ramon Poca
+- akeonly
+- Omer Akram
+- Justin Vieira
+
+2018-05-15 - Version 3.0a4 - "Kakistocrat"
+------------------------------------------
+This release is the fifth alpha release of the new version 3.0. Please
+be aware that the API will still change until v3.0 is released.
+
+changes
+^^^^^^^
+- raise exception when TypeError occurs in cashdraw (#268)
+- Feature/clear content in dummy printer (#271)
+- fix is_online() (#282)
+- improve documentation
+- Modified submodule to always pull from master branch (#283)
+- parameter for implementation of nonnative qrcode (#289)
+- improve platform independence (#296)
+
+contributors
+^^^^^^^^^^^^
+- Christoph Heuel
+- Patrick Kanzler
+- kennedy
+- primax79
+- reck31
+- Thijs Triemstra
+
+2017-10-08 - Version 3.0a3 - "Just Testing"
+-------------------------------------------
+This release is the fourth alpha release of the new version 3.0. Please
+be aware that the API will still change until v3.0 is released.
+
+changes
+^^^^^^^
+- minor changes in documentation, tests and examples
+- pickle capabilities for faster startup
+- first implementation of centering images and QR
+- check barcodes based on regex
+
+contributors
+^^^^^^^^^^^^
+- Patrick Kanzler
+- Lucy Linder
+- Romain Porte
+- Sergio Pulgarin

 2017-08-04 - Version 3.0a2 - "It's My Party And I'll Sing If I Want To"
 -----------------------------------------------------------------------
--- a/CONTRIBUTING.rst
+++ b/CONTRIBUTING.rst
@@ -20,6 +20,7 @@ When contributing the first time, please include a commit with the output of thi
 Otherwise the integration-check will fail.

 When you change your username or mail-address, please also update the `.mailmap` and the authors-list.
+You can find a good documentation on the mapping-feature in the `documentation of git-shortlog <https://git-scm.com/docs/git-shortlog#_mapping_authors>`_.

 Style-Guide
 -----------
@@ -47,9 +48,11 @@ Often you can achieve compatibility quite easily with a tool from the `six`-pack

 PEP8
 ^^^^
-This is not yet consequently done in every piece of code, but please try to ensure
-that your code honors PEP8.
-The checks by Landscape and QuantifiedCode that run on every PR will provide you with hints.
+The entire codebase adheres to the rules of PEP8.
+These rules are enforced by running `flake8` in the integration-checks.
+Please adhere to these rules as your contribution can only be merged if the check succeeds.
+You can use flake8 or similar tools locally in order to check your code.
+Apart from that the travis-log and the check by Landscape will provide you with hints.

 GIT
 ^^^
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -1,6 +1,5 @@
 include *.rst
 include *.txt
-include COPYING
 include LICENSE
 include INSTALL
 include tox.ini
--- a/README.rst
+++ b/README.rst
@@ -62,12 +62,34 @@ The basic usage is:
    p = Usb(0x04b8, 0x0202, 0, profile="TM-T88III")
    p.text("Hello World\n")
    p.image("logo.gif")
-    p.barcode('1324354657687', 'EAN13', 64, 2, '', '')
+    p.barcode('4006381333931', 'EAN13', 64, 2, '', '')
    p.cut()

+
+Another example based on the Network printer class:
+
+.. code:: python
+
+    from escpos.printer import Network
+    
+    kitchen = Network("192.168.1.100") #Printer IP Address
+    kitchen.text("Hello World\n")
+    kitchen.barcode('4006381333931', 'EAN13', 64, 2, '', '')
+    kitchen.cut()
+
+
 The full project-documentation is available on `Read the Docs <https://python-escpos.readthedocs.io>`_.

 Contributing
 ------------

-This project is open for any contribution! Please see CONTRIBUTING.rst for more information.
+This project is open for any contribution! Please see `CONTRIBUTING.rst <http://python-escpos.readthedocs.io/en/latest/dev/contributing.html>`_ for more information.
+
+
+Disclaimer
+----------
+
+None of the vendors cited in this project agree or endorse any of the patterns or implementations.
+Its names are used only to maintain context.
+
+
--- a/2
+++ b/2
--- a/doc/generate_authors.sh
+++ b/doc/generate_authors.sh
@@ -1,6 +1,6 @@
 #!/bin/sh

-GENLIST=$(git shortlog -s -n | cut -f2 | sort)
+GENLIST=$(git shortlog -s -n | cut -f2 | sort -f)
 AUTHORSFILE="$(dirname $0)/../AUTHORS"
 TEMPAUTHORSFILE="/tmp/python-escpos-authorsfile"

--- a/doc/user/todo.rst
+++ b/doc/user/todo.rst
@@ -2,38 +2,9 @@
 TODO
 ****

-Introduction
------------
-
-python-escpos is the initial idea, from here we can start to build a
-robust library to get most of the ESC/POS printers working with this
-library.
-
-Eventually, this library must be able to cover almost all the defined
-models detailed in the ESC/POS Command Specification Manual.
-
-Details
-------
-
-What things are planned to work on?
-
-Testing
-~~~~~~~
-
-* Test on many printers as possible (USB, Serial, Network)
-* automate testing
-
-Design
-~~~~~~
-
-* Add all those sequences which are not common, but part of the ESC/POS
-  Command Specifications.
-
-  *  Port to Python 3
-  *  Windows compatibility (hidapi instead libusb?)
-  *  PDF417 support
-
-* use something similar to the `capabilities` in escpos-php
+Open points and issues of the project are tracked in the GitHub issues.
+Some annotations still remain in the code and should be moved over time
+into the issue tracker.

 Todos in the codebase
 ~~~~~~~~~~~~~~~~~~~~~
--- a/doc/user/usage.rst
+++ b/doc/user/usage.rst
@@ -44,7 +44,7 @@ to have and the second yields the "Output Endpoint" address.

 ::

-    Epson = printer.Usb(0x04b8,0x0202)
+    p = printer.Usb(0x04b8,0x0202)

 By default the "Interface" number is "0" and the "Output Endpoint"
 address is "0x01". If you have other values then you can define them on
@@ -55,7 +55,7 @@ on 0x81 and out\_ep=0x02, then the printer definition should look like:

 ::

-    Generic = printer.Usb(0x1a2b,0x1a2b,0,0x81,0x02)
+    p = printer.Usb(0x1a2b,0x1a2b,0,0x81,0x02)

 Network printer
 ^^^^^^^^^^^^^^^
@@ -67,7 +67,7 @@ IP by DHCP or you set it manually.

 ::

-    Epson = printer.Network("192.168.1.99")
+    p = printer.Network("192.168.1.99")

 Serial printer
 ^^^^^^^^^^^^^^
@@ -81,7 +81,10 @@ to.

 ::

-    Epson = printer.Serial("/dev/tty0")
+    p = printer.Serial("/dev/tty0")
+    
+    # on a Windows OS serial devices are typically accessible as COM
+    p = printer.Serial("COM1")

 Other printers
 ^^^^^^^^^^^^^^
@@ -93,7 +96,7 @@ passing the device node name.

 ::

-    Epson = printer.File("/dev/usb/lp1")
+    p = printer.File("/dev/usb/lp1")

 The default is "/dev/usb/lp0", so if the printer is located on that
 node, then you don't necessary need to pass the node name.
@@ -108,17 +111,17 @@ on a USB interface.

    from escpos import *
    """ Seiko Epson Corp. Receipt Printer M129 Definitions (EPSON TM-T88IV) """
-    Epson = printer.Usb(0x04b8,0x0202)
+    p = printer.Usb(0x04b8,0x0202)
    # Print text
-    Epson.text("Hello World\n")
+    p.text("Hello World\n")
    # Print image
-    Epson.image("logo.gif")
+    p.image("logo.gif")
    # Print QR Code
-    Epson.qr("You can readme from your smartphone")
+    p.qr("You can readme from your smartphone")
    # Print barcode
-    Epson.barcode('1324354657687','EAN13',64,2,'','')
+    p.barcode('4006381333931','EAN13',64,2,'','')
    # Cut paper
-    Epson.cut()
+    p.cut()

 Configuration File
 ------------------
--- a/examples/codepage_tables.py
+++ b/examples/codepage_tables.py
@@ -37,14 +37,14 @@ def print_codepage(printer, codepage):
    sep = ""

    # Table header
-    printer.set(text_type='B')
+    printer.set(font='b')
    printer._raw("  {}\n".format(sep.join(map(lambda s: hex(s)[2:], range(0, 16)))))
    printer.set()

    # The table
    for x in range(0, 16):
        # First column
-        printer.set(text_type='B')
+        printer.set(font='b')
        printer._raw("{} ".format(hex(x)[2:]))
        printer.set()

--- a/examples/qr_code.py
+++ b/examples/qr_code.py
@@ -16,4 +16,4 @@ if __name__ == '__main__':

    # Adapt to your needs
    p = Usb(0x0416, 0x5011, profile="POS-5890")
-    p.qr(content)
+    p.qr(content, center=True)
--- a/examples/weather.py
+++ b/examples/weather.py
@@ -123,5 +123,5 @@ printer.set(font='a', height=2, align='center', bold=True, double_height=False)
 printer.text('Forecast: \n')
 forecast(0)
 forecast(1)
-printer.cut
+printer.cut()
 printer.control("LF")
--- a/setup.py
+++ b/setup.py
@@ -3,7 +3,6 @@
 import os
 import sys
 from setuptools import find_packages, setup
-from setuptools.command.test import test as test_command


 base_dir = os.path.dirname(__file__)
@@ -19,33 +18,6 @@ def read(fname):
    return open(os.path.join(os.path.dirname(__file__), fname)).read()


-class Tox(test_command):
-    """proxy class that enables tox to be run with setup.py test"""
-    user_options = [('tox-args=', 'a', "Arguments to pass to tox")]
-
-    def initialize_options(self):
-        """initialize the user-options"""
-        test_command.initialize_options(self)
-        self.tox_args = None
-
-    def finalize_options(self):
-        """finalize user-options"""
-        test_command.finalize_options(self)
-        self.test_args = []
-        self.test_suite = True
-
-    def run_tests(self):
-        """run tox and pass on user-options"""
-        # import here, cause outside the eggs aren't loaded
-        import tox
-        import shlex
-        args = self.tox_args
-        if args:
-            args = shlex.split(self.tox_args)
-        errno = tox.cmdline(args=args)
-        sys.exit(errno)
-
-
 setuptools_scm_template = """\
 # coding: utf-8
 # file generated by setuptools_scm
@@ -68,7 +40,6 @@ setup(
    url='https://github.com/python-escpos/python-escpos',
    download_url='https://github.com/python-escpos/python-escpos/archive/master.zip',
    description='Python library to manipulate ESC/POS Printers',
-    bugtrack_url='https://github.com/python-escpos/python-escpos/issues',
    license='MIT',
    long_description=read('README.rst'),
    author='Manuel F Martinez and others',
@@ -85,7 +56,7 @@ setup(
    platforms='any',
    package_dir={"": "src"},
    packages=find_packages(where="src", exclude=["tests", "tests.*"]),
-    package_data={'': ['COPYING', 'src/escpos/capabilities.json']},
+    package_data={'escpos': ['capabilities.json']},
    include_package_data=True,
    classifiers=[
        'Development Status :: 4 - Beta',
@@ -94,10 +65,7 @@ setup(
        'License :: OSI Approved :: MIT License',
        'Operating System :: OS Independent',
        'Programming Language :: Python',
-        'Programming Language :: Python :: 2',
-        'Programming Language :: Python :: 2.7',
        'Programming Language :: Python :: 3',
-        'Programming Language :: Python :: 3.3',
        'Programming Language :: Python :: 3.4',
        'Programming Language :: Python :: 3.5',
        'Programming Language :: Python :: 3.6',
@@ -114,7 +82,7 @@ setup(
        'pyserial',
        'six',
        'appdirs',
-        'pyyaml',
+        'PyYAML',
        'argparse',
        'argcomplete',
        'future',
@@ -126,16 +94,15 @@ setup(
    tests_require=[
        'jaconv',
        'tox',
-        'pytest!=3.2.0',
+        'pytest!=3.2.0,!=3.3.0',
        'pytest-cov',
        'pytest-mock',
        'nose',
        'scripttest',
        'mock',
-        'hypothesis',
+        'hypothesis!=3.56.9,<4',
        'flake8'
    ],
-    cmdclass={'test': Tox},
    entry_points={
        'console_scripts': [
            'python-escpos = escpos.cli:main'
--- a/src/escpos/capabilities.py
+++ b/src/escpos/capabilities.py
@@ -1,22 +1,54 @@
 import re
-import six
 from os import environ, path
+import pickle
+import logging
+import time
+
+import six
 import yaml

-# Load external printer database
-if 'ESCPOS_CAPABILITIES_FILE' in environ:
-    file_path = environ['ESCPOS_CAPABILITIES_FILE']
-else:
-    file_path = path.join(path.dirname(__file__), 'capabilities.json')
+from tempfile import gettempdir
+import platform
+
+logging.basicConfig()
+logger = logging.getLogger(__name__)
+
+pickle_dir = environ.get('ESCPOS_CAPABILITIES_PICKLE_DIR', gettempdir())
+pickle_path = path.join(pickle_dir, '{v}.capabilities.pickle'.format(v=platform.python_version()))
+capabilities_path = environ.get(
+    'ESCPOS_CAPABILITIES_FILE',
+    path.join(path.dirname(__file__), 'capabilities.json'))
+
+# Load external printer database
+t0 = time.time()
+logger.debug('Using capabilities from file: %s', capabilities_path)
+if path.exists(pickle_path):
+    if path.getmtime(capabilities_path) > path.getmtime(pickle_path):
+        logger.debug('Found a more recent capabilities file')
+        full_load = True
+    else:
+        full_load = False
+        logger.debug('Loading capabilities from pickle in %s', pickle_path)
+        with open(pickle_path, 'rb') as cf:
+            CAPABILITIES = pickle.load(cf)
+else:
+    logger.debug('Capabilities pickle file not found: %s', pickle_path)
+    full_load = True
+
+if full_load:
+    logger.debug('Loading and pickling capabilities')
+    with open(capabilities_path) as cp, open(pickle_path, 'wb') as pp:
+        CAPABILITIES = yaml.safe_load(cp)
+        pickle.dump(CAPABILITIES, pp, protocol=2)
+
+logger.debug('Finished loading capabilities took %.2fs', time.time() - t0)

-with open(file_path) as f:
-    CAPABILITIES = yaml.load(f)

 PROFILES = CAPABILITIES['profiles']


 class NotSupported(Exception):
-    """Raised if a requested feature is not suppored by the
+    """Raised if a requested feature is not supported by the
    printer profile.
    """
    pass
@@ -59,7 +91,7 @@ class BaseProfile(object):
        return self.features.get(feature)

    def get_code_pages(self):
-        """Return the support code pages as a {name: index} dict.
+        """Return the support code pages as a ``{name: index}`` dict.
        """
        return {v: k for k, v in self.codePages.items()}

--- a/src/escpos/cli.py
+++ b/src/escpos/cli.py
@@ -53,7 +53,7 @@ DEMO_FUNCTIONS = {
    'barcodes_a': [
        {'bc': 'UPC-A', 'code': '13243546576'},
        {'bc': 'UPC-E', 'code': '132435'},
-        {'bc': 'EAN13', 'code': '1324354657687'},
+        {'bc': 'EAN13', 'code': '4006381333931'},
        {'bc': 'EAN8', 'code': '1324354'},
        {'bc': 'CODE39', 'code': 'TEST'},
        {'bc': 'ITF', 'code': '55867492279103'},
@@ -62,13 +62,13 @@ DEMO_FUNCTIONS = {
    'barcodes_b': [
        {'bc': 'UPC-A', 'code': '13243546576', 'function_type': 'B'},
        {'bc': 'UPC-E', 'code': '132435', 'function_type': 'B'},
-        {'bc': 'EAN13', 'code': '1324354657687', 'function_type': 'B'},
+        {'bc': 'EAN13', 'code': '4006381333931', 'function_type': 'B'},
        {'bc': 'EAN8', 'code': '1324354', 'function_type': 'B'},
        {'bc': 'CODE39', 'code': 'TEST', 'function_type': 'B'},
        {'bc': 'ITF', 'code': '55867492279103', 'function_type': 'B'},
        {'bc': 'NW7', 'code': 'A00000000A', 'function_type': 'B'},
        {'bc': 'CODE93', 'code': 'A00000000A', 'function_type': 'B'},
-        {'bc': 'CODE93', 'code': '1324354657687', 'function_type': 'B'},
+        {'bc': 'CODE93', 'code': '4006381333931', 'function_type': 'B'},
        {'bc': 'CODE128A', 'code': 'TEST', 'function_type': 'B'},
        {'bc': 'CODE128B', 'code': 'TEST', 'function_type': 'B'},
        {'bc': 'CODE128C', 'code': 'TEST', 'function_type': 'B'},
--- a/src/escpos/constants.py
+++ b/src/escpos/constants.py
@@ -225,6 +225,24 @@ BARCODE_TYPE_B = {
    'GS1 DATABAR EXPANDED':        _SET_BARCODE_TYPE(78),
 }

+BARCODE_FORMATS = {
+    'UPC-A':                       ([(11, 12)], "^[0-9]{11,12}$"),
+    'UPC-E':                       ([(7, 8), (11, 12)], "^([0-9]{7,8}|[0-9]{11,12})$"),
+    'EAN13':                       ([(12, 13)], "^[0-9]{12,13}$"),
+    'EAN8':                        ([(7, 8)], "^[0-9]{7,8}$"),
+    'CODE39':                      ([(1, 255)], "^([0-9A-Z \$\%\+\-\.\/]+|\*[0-9A-Z \$\%\+\-\.\/]+\*)$"),
+    'ITF':                         ([(2, 255)], "^([0-9]{2})+$"),
+    'NW7':                         ([(1, 255)], "^[A-Da-d][0-9\$\+\-\.\/\:]+[A-Da-d]$"),
+    'CODABAR':                     ([(1, 255)], "^[A-Da-d][0-9\$\+\-\.\/\:]+[A-Da-d]$"),  # Same as NW7
+    'CODE93':                      ([(1, 255)], "^[\\x00-\\x7F]+$"),
+    'CODE128':                     ([(2, 255)], "^\{[A-C][\\x00-\\x7F]+$"),
+    'GS1-128':                     ([(2, 255)], "^\{[A-C][\\x00-\\x7F]+$"), # same as CODE128
+    'GS1 DATABAR OMNIDIRECTIONAL': ([(13,13)], "^[0-9]{13}$"),
+    'GS1 DATABAR TRUNCATED':       ([(13,13)], "^[0-9]{13}$"), # same as GS1 omnidirectional
+    'GS1 DATABAR LIMITED':         ([(13,13)], "^[01][0-9]{12}$"),
+    'GS1 DATABAR EXPANDED':        ([(2,255)], "^\([0-9][A-Za-z0-9 \!\"\%\&\'\(\)\*\+\,\-\.\/\:\;\<\=\>\?\_\{]+$"),
+}
+
 BARCODE_TYPES = {
    'A': BARCODE_TYPE_A,
    'B': BARCODE_TYPE_B,
--- a/src/escpos/escpos.py
+++ b/src/escpos/escpos.py
@@ -19,13 +19,16 @@ import qrcode
 import textwrap
 import six
 import time
+from re import match as re_match

 import barcode
 from barcode.writer import ImageWriter

+import os
+
 from .constants import ESC, GS, NUL, QR_ECLEVEL_L, QR_ECLEVEL_M, QR_ECLEVEL_H, QR_ECLEVEL_Q
 from .constants import QR_MODEL_1, QR_MODEL_2, QR_MICRO, BARCODE_TYPES, BARCODE_HEIGHT, BARCODE_WIDTH
-from .constants import BARCODE_FONT_A, BARCODE_FONT_B
+from .constants import BARCODE_FONT_A, BARCODE_FONT_B, BARCODE_FORMATS
 from .constants import BARCODE_TXT_OFF, BARCODE_TXT_BTH, BARCODE_TXT_ABV, BARCODE_TXT_BLW
 from .constants import TXT_SIZE, TXT_NORMAL
 from .constants import SET_FONT
@@ -80,14 +83,14 @@ class Escpos(object):
        """
        pass

-    def _read(self, msg):
+    def _read(self):
        """ Returns a NotImplementedError if the instance of the class doesn't override this method.
        :raises NotImplementedError
        """
        raise NotImplementedError()

    def image(self, img_source, high_density_vertical=True, high_density_horizontal=True, impl="bitImageRaster",
-              fragment_height=960):
+              fragment_height=960, center=False):
        """ Print an image

        You can select whether the printer should print in high density or not. The default value is high density.
@@ -108,14 +111,19 @@ class Escpos(object):
        :param high_density_horizontal: print in high density in horizontal direction *default:* True
        :param impl: choose image printing mode between `bitImageRaster`, `graphics` or `bitImageColumn`
        :param fragment_height: Images larger than this will be split into multiple fragments *default:* 960
+        :param center: Center image horizontally *default:* False

        """
        im = EscposImage(img_source)

        try:
            max_width = int(self.profile.profile_data['media']['width']['pixels'])
+
            if im.width > max_width:
                raise ImageWidthError('{} > {}'.format(im.width, max_width))
+
+            if center:
+                im.center(max_width)
        except KeyError:
            # If the printer's pixel width is not known, print anyways...
            pass
@@ -173,7 +181,8 @@ class Escpos(object):
        header = self._int_low_high(len(data) + 2, 2)
        self._raw(GS + b'(L' + header + m + fn + data)

-    def qr(self, content, ec=QR_ECLEVEL_L, size=3, model=QR_MODEL_2, native=False):
+    def qr(self, content, ec=QR_ECLEVEL_L, size=3, model=QR_MODEL_2,
+           native=False, center=False, impl="bitImageRaster"):
        """ Print QR Code for the provided string

        :param content: The content of the code. Numeric data will be more efficiently compacted.
@@ -185,6 +194,8 @@ class Escpos(object):
            by all printers).
        :param native: True to render the code on the printer, False to render the code as an image and send it to the
            printer (Default)
+        :param center: Centers the code *default:* False
+        :param impl: Image-printing-implementation, refer to :meth:`.image()` for details
        """
        # Basic validation
        if ec not in [QR_ECLEVEL_L, QR_ECLEVEL_M, QR_ECLEVEL_H, QR_ECLEVEL_Q]:
@@ -211,12 +222,17 @@ class Escpos(object):
            qr_code.make(fit=True)
            qr_img = qr_code.make_image()
            im = qr_img._img.convert("RGB")
+
            # Convert the RGB image in printable image
            self.text('\n')
-            self.image(im)
+            self.image(im, center=center, impl=impl)
            self.text('\n')
            self.text('\n')
            return
+
+        if center:
+            raise NotImplementedError("Centering not implemented for native QR rendering")
+
        # Native 2D code printing
        cn = b'1'  # Code type for QR code
        # Select model: 1, 2 or micro.
@@ -275,17 +291,42 @@ class Escpos(object):
        else:
            self.magic.force_encoding(code)

+    @staticmethod
+    def check_barcode(bc, code):
+        """
+        This method checks if the barcode is in the proper format.
+        The validation concerns the barcode length and the set of characters, but won't compute/validate any checksum.
+        The full set of requirement for each barcode type is available in the ESC/POS documentation.
+
+        As an example, using EAN13, the barcode `12345678901` will be correct, because it can be rendered by the
+        printer. But it does not suit the EAN13 standard, because the checksum digit is missing. Adding a wrong
+        checksum in the end will also be considered correct, but adding a letter won't (EAN13 is numeric only).
+
+        .. todo:: Add a method to compute the checksum for the different standards
+
+        .. todo:: For fixed-length standards with mandatory checksum (EAN, UPC),
+            compute and add the checksum automatically if missing.
+
+        :param bc: barcode format, see :py:meth:`.barcode()`
+        :param code: alphanumeric data to be printed as bar code, see :py:meth:`.barcode()`
+        :return: bool
+        """
+        if bc not in BARCODE_FORMATS:
+            return False
+
+        bounds, regex = BARCODE_FORMATS[bc]
+        return any(bound[0] <= len(code) <= bound[1] for bound in bounds) and re_match(regex, code)
+
    def barcode(self, code, bc, height=64, width=3, pos="BELOW", font="A",
-                align_ct=True, function_type=None):
+                align_ct=True, function_type=None, check=True):
        """ Print Barcode

        This method allows to print barcodes. The rendering of the barcode is done by the printer and therefore has to
-        be supported by the unit. Currently you have to check manually whether your barcode text is correct. Uncorrect
-        barcodes may lead to unexpected printer behaviour. There are two forms of the barcode function. Type A is
-        default but has fewer barcodes, while type B has some more to choose from.
-
-        .. todo:: Add a method to check barcode codes. Alternatively or as an addition write explanations about each
-                  barcode-type. Research whether the check digits can be computed autmatically.
+        be supported by the unit. By default, this method will check whether your barcode text is correct, that is
+        the characters and lengths are supported by ESCPOS. Call the method with `check=False` to disable the check, but
+        note that uncorrect barcodes may lead to unexpected printer behaviour.
+        There are two forms of the barcode function. Type A is default but has fewer barcodes,
+        while type B has some more to choose from.

        Use the parameters `height` and `width` for adjusting of the barcode size. Please take notice that the barcode
        will not be printed if it is outside of the printable area. (Which should be impossible with this method, so
@@ -353,6 +394,10 @@ class Escpos(object):
            function based on the current profile.
            *default*: A

+        :param check: If this parameter is True, the barcode format will be checked to ensure it meets the bc
+            requirements as defigned in the esc/pos documentation. See :py:meth:`.check_barcode()`
+            for more information. *default*: True.
+
        :raises: :py:exc:`~escpos.exceptions.BarcodeSizeError`,
                 :py:exc:`~escpos.exceptions.BarcodeTypeError`,
                 :py:exc:`~escpos.exceptions.BarcodeCodeError`
@@ -375,12 +420,19 @@ class Escpos(object):
        bc_types = BARCODE_TYPES[function_type.upper()]
        if bc.upper() not in bc_types.keys():
            raise BarcodeTypeError((
-                "Barcode type '{bc}' not valid for barcode function type "
+                "Barcode '{bc}' not valid for barcode function type "
                "{function_type}").format(
                    bc=bc,
                    function_type=function_type,
                ))

+        if check and not self.check_barcode(bc, code):
+            raise BarcodeCodeError((
+                "Barcode '{code}' not in a valid format for type '{bc}'").format(
+                code=code,
+                bc=bc,
+            ))
+
        # Align Bar Code()
        if align_ct:
            self._raw(TXT_STYLE['align']['center'])
@@ -438,11 +490,12 @@ class Escpos(object):
        barcode_class = barcode.get_barcode_class(barcode_type)
        my_code = barcode_class(data, writer=image_writer)

-        my_code.write("/dev/null", {
-            'module_height': module_height,
-            'module_width': module_width,
-            'text_distance': text_distance
-        })
+        with open(os.devnull, "wb") as nullfile:
+            my_code.write(nullfile, {
+                'module_height': module_height,
+                'module_width': module_width,
+                'text_distance': text_distance
+            })

        # Retrieve the Pillow image and print it
        image = my_code.writer._image
@@ -648,8 +701,8 @@ class Escpos(object):
        else:
            try:
                self._raw(CD_KICK_DEC_SEQUENCE(*pin))
-            except:
-                raise CashDrawerError()
+            except TypeError as err:
+                raise CashDrawerError(err)

    def linedisplay_select(self, select_display=False):
        """ Selects the line display or the printer
@@ -679,6 +732,7 @@ class Escpos(object):

        You should connect a line display to your printer. You can do this by daisy-chaining
        the display between your computer and printer.
+
        :param text: Text to display
        """
        self.linedisplay_select(select_display=True)
@@ -778,30 +832,41 @@ class Escpos(object):
            self._raw(PANEL_BUTTON_OFF)

    def query_status(self, mode):
-        """ Queries the printer for its status, and returns an array of integers containing it.
+        """
+        Queries the printer for its status, and returns an array of integers containing it.
+
        :param mode: Integer that sets the status mode queried to the printer.
-        RT_STATUS_ONLINE: Printer status.
-        RT_STATUS_PAPER: Paper sensor.
-        :rtype: array(integer)"""
+            - RT_STATUS_ONLINE: Printer status.
+            - RT_STATUS_PAPER: Paper sensor.
+        :rtype: array(integer)
+        """
        self._raw(mode)
        time.sleep(1)
        status = self._read()
        return status

    def is_online(self):
-        """ Queries the printer its online status.
-        When online, returns True; False otherwise.
-        :rtype: bool: True if online, False if offline."""
+        """
+        Queries the online status of the printer.
+
+        :returns: When online, returns ``True``; ``False`` otherwise.
+        :rtype: bool
+        """
        status = self.query_status(RT_STATUS_ONLINE)
        if len(status) == 0:
            return False
-        return not (status & RT_MASK_ONLINE)
+        return not (status[0] & RT_MASK_ONLINE)

    def paper_status(self):
-        """ Queries the printer its paper status.
+        """
+        Queries the paper status of the printer.
+
        Returns 2 if there is plenty of paper, 1 if the paper has arrived to
        the near-end sensor and 0 if there is no paper.
-        :rtype: int: 2: Paper is adequate. 1: Paper ending. 0: No paper."""
+
+        :returns: 2: Paper is adequate. 1: Paper ending. 0: No paper.
+        :rtype: int
+        """
        status = self.query_status(RT_STATUS_PAPER)
        if len(status) == 0:
            return 2
@@ -817,7 +882,7 @@ class EscposIO(object):
    """ESC/POS Printer IO object

    Allows the class to be used together with the `with`-statement. You have to define a printer instance
-    and assign it to the EsposIO-class.
+    and assign it to the EscposIO class.
    This example explains the usage:

    .. code-block:: Python
--- a/src/escpos/exceptions.py
+++ b/src/escpos/exceptions.py
@@ -77,9 +77,10 @@ class BarcodeSizeError(Error):


 class BarcodeCodeError(Error):
-    """ No Barcode code was supplied.
+    """ No Barcode code was supplied, or it is incorrect.

-    No data for the barcode has been supplied in :py:meth:`escpos.escpos.Escpos.barcode`.
+    No data for the barcode has been supplied in :py:meth:`escpos.escpos.Escpos.barcode` or the the `check` parameter
+    was True and the check failed.
    The returncode for this exception is `30`.
    """
    def __init__(self, msg=""):
--- a/src/escpos/image.py
+++ b/src/escpos/image.py
@@ -115,3 +115,19 @@ class EscposImage(object):
            box = (left, upper, right, lower)
            fragments.append(self.img_original.crop(box))
        return fragments
+
+    def center(self, max_width):
+        """In-place image centering
+
+        :param: Maximum width in order to deduce x offset for centering
+        :return: None
+        """
+        old_width, height = self._im.size
+        new_size = (max_width, height)
+
+        new_im = Image.new("1", new_size)
+        paste_x = int((max_width - old_width) / 2)
+
+        new_im.paste(self._im, (paste_x, 0))
+
+        self._im = new_im
--- a/src/escpos/printer.py
+++ b/src/escpos/printer.py
@@ -34,41 +34,58 @@ class Usb(Escpos):

    """

-    def __init__(self, idVendor, idProduct, timeout=0, in_ep=0x82, out_ep=0x01, *args, **kwargs):  # noqa: N803
+    def __init__(self, idVendor, idProduct, usb_args=None, timeout=0, in_ep=0x82, out_ep=0x01,
+                 *args, **kwargs):  # noqa: N803
        """
        :param idVendor: Vendor ID
        :param idProduct: Product ID
+        :param usb_args: Optional USB arguments (e.g. custom_match)
        :param timeout: Is the time limit of the USB operation. Default without timeout.
        :param in_ep: Input end point
        :param out_ep: Output end point
        """
        Escpos.__init__(self, *args, **kwargs)
-        self.idVendor = idVendor
-        self.idProduct = idProduct
        self.timeout = timeout
        self.in_ep = in_ep
        self.out_ep = out_ep
-        self.open()

-    def open(self):
-        """ Search device on USB tree and set it as escpos device """
-        self.device = usb.core.find(idVendor=self.idVendor, idProduct=self.idProduct)
+        usb_args = usb_args or {}
+        if idVendor:
+            usb_args['idVendor'] = idVendor
+        if idProduct:
+            usb_args['idProduct'] = idProduct
+        self.open(usb_args)
+
+    def open(self, usb_args):
+        """ Search device on USB tree and set it as escpos device.
+
+        :param usb_args: USB arguments
+        """
+        self.device = usb.core.find(**usb_args)
        if self.device is None:
            raise USBNotFoundError("Device not found or cable not plugged in.")

-        check_driver = None
+        self.idVendor = self.device.idVendor
+        self.idProduct = self.device.idProduct

-        try:
-            check_driver = self.device.is_kernel_driver_active(0)
-        except NotImplementedError:
-            pass
+        # pyusb has three backends: libusb0, libusb1 and openusb but
+        # only libusb1 backend implements the methods is_kernel_driver_active()
+        # and detach_kernel_driver().
+        # This helps enable this library to work on Windows.
+        if self.device.backend.__module__.endswith("libusb1"):
+            check_driver = None

-        if check_driver is None or check_driver:
            try:
-                self.device.detach_kernel_driver(0)
-            except usb.core.USBError as e:
-                if check_driver is not None:
-                    print("Could not detatch kernel driver: {0}".format(str(e)))
+                check_driver = self.device.is_kernel_driver_active(0)
+            except NotImplementedError:
+                pass
+
+            if check_driver is None or check_driver:
+                try:
+                    self.device.detach_kernel_driver(0)
+                except usb.core.USBError as e:
+                    if check_driver is not None:
+                        print("Could not detatch kernel driver: {0}".format(str(e)))

        try:
            self.device.set_configuration()
@@ -219,6 +236,11 @@ class Network(Escpos):
        """
        self.device.sendall(msg)

+    def _read(self):
+        """ Read data from the TCP socket """
+
+        return self.device.recv(16)
+
    def close(self):
        """ Close TCP connection """
        if self.device is not None:
@@ -243,7 +265,7 @@ class File(Escpos):
    def __init__(self, devfile="/dev/usb/lp0", auto_flush=True, *args, **kwargs):
        """

-        :param devfile : Device file under dev filesystem
+        :param devfile: Device file under dev filesystem
        :param auto_flush: automatically call flush after every call of _raw()
        """
        Escpos.__init__(self, *args, **kwargs)
@@ -312,5 +334,58 @@ class Dummy(Escpos):
        """ Get the data that was sent to this printer """
        return b''.join(self._output_list)

+    def clear(self):
+        """ Clear the buffer of the printer
+
+        This method can be called if you send the contents to a physical printer
+        and want to use the Dummy printer for new output.
+        """
+        del self._output_list[:]
+
    def close(self):
        pass
+
+
+_WIN32PRINT = False
+try:
+    import win32print
+    _WIN32PRINT = True
+except ImportError:
+    pass
+
+if _WIN32PRINT:
+    class Win32Raw(Escpos):
+        def __init__(self, printer_name=None, *args, **kwargs):
+            Escpos.__init__(self, *args, **kwargs)
+            if printer_name is not None:
+                self.printer_name = printer_name
+            else:
+                self.printer_name = win32print.GetDefaultPrinter()
+            self.hPrinter = None
+
+        def open(self, job_name="python-escpos"):
+            if self.printer_name is None:
+                raise Exception("Printer not found")
+            self.hPrinter = win32print.OpenPrinter(self.printer_name)
+            self.current_job = win32print.StartDocPrinter(self.hPrinter, 1, (job_name, None, "RAW"))
+            win32print.StartPagePrinter(self.hPrinter)
+
+        def close(self):
+            if not self.hPrinter:
+                return
+            win32print.EndPagePrinter(self.hPrinter)
+            win32print.EndDocPrinter(self.hPrinter)
+            win32print.ClosePrinter(self.hPrinter)
+            self.hPrinter = None
+
+        def _raw(self, msg):
+            """ Print any command sent in raw format
+
+            :param msg: arbitrary code to be printed
+            :type msg: bytes
+            """
+            if self.printer_name is None:
+                raise Exception("Printer not found")
+            if self.hPrinter is None:
+                raise Exception("Printer job not opened")
+            win32print.WritePrinter(self.hPrinter, msg)
--- a/test/test_function_barcode.py
+++ b/test/test_function_barcode.py
@@ -7,7 +7,7 @@ from __future__ import unicode_literals
 import escpos.printer as printer
 from escpos.constants import BARCODE_TYPE_A, BARCODE_TYPE_B
 from escpos.capabilities import Profile, BARCODE_B
-from escpos.exceptions import BarcodeTypeError
+from escpos.exceptions import BarcodeTypeError, BarcodeCodeError
 import pytest


@@ -36,3 +36,17 @@ def test_lacks_support(bctype, supports_b):
        instance.barcode('test', bctype)

    assert instance.output == b''
+
+
+@pytest.mark.parametrize("bctype,data", [
+    ('EAN13', 'AA'),
+    ('CODE128', '{D2354AA'),
+])
+def test_code_check(bctype, data):
+    """should raise an error if the barcode code is invalid.
+    """
+    instance = printer.Dummy()
+    with pytest.raises(BarcodeCodeError):
+        instance.barcode(data, bctype)
+
+    assert instance.output == b''
--- a/test/test_function_cashdraw.py
+++ b/test/test_function_cashdraw.py
@@ -0,0 +1,19 @@
+#!/usr/bin/python
+from __future__ import absolute_import
+from __future__ import division
+from __future__ import print_function
+from __future__ import unicode_literals
+
+import escpos.printer as printer
+from escpos.exceptions import CashDrawerError
+import pytest
+
+
+def test_raise_CashDrawerError():
+    """should raise an error if the sequence is invalid.
+    """
+    instance = printer.Dummy()
+    with pytest.raises(CashDrawerError):
+        # call with sequence that is too long
+        instance.cashdraw([1,1,1,1,1,1])
+
--- a/test/test_function_check_barcode.py
+++ b/test/test_function_check_barcode.py
@@ -0,0 +1,104 @@
+#!/usr/bin/python
+# -*- coding: utf-8 -*-
+
+from __future__ import absolute_import
+from __future__ import division
+from __future__ import print_function
+from __future__ import unicode_literals
+
+import escpos.printer as printer
+import pytest
+
+
+@pytest.mark.parametrize("bctype,data", [
+    ('UPC-A', '01234567890'),
+    ('UPC-A', '012345678905'),
+    ('UPC-E', '01234567'),
+    ('UPC-E', '0123456'),
+    ('UPC-E', '012345678905'),
+    ('EAN13', '0123456789012'),
+    ('EAN13', '012345678901'),
+    ('EAN8', '01234567'),
+    ('EAN8', '0123456'),
+    ('CODE39', 'ABC-1234'),
+    ('CODE39', 'ABC-1234-$$-+A'),
+    ('CODE39', '*WIKIPEDIA*'),
+    ('ITF', '010203040506070809'),
+    ('ITF', '11221133113344556677889900'),
+    ('CODABAR', 'A2030405060B'),
+    ('CODABAR', 'C11221133113344556677889900D'),
+    ('CODABAR', 'D0D'),
+    ('NW7', 'A2030405060B'),
+    ('NW7', 'C11221133113344556677889900D'),
+    ('NW7', 'D0D'),
+    ('CODE93', 'A2030405060B'),
+    ('CODE93', '+:$&23-7@$'),
+    ('CODE93', 'D0D'),
+    ('CODE128', '{A2030405060B'),
+    ('CODE128', '{C+:$&23-7@$'),
+    ('CODE128', '{B0D'),
+    ('GS1-128', '{A2030405060B'),
+    ('GS1-128', '{C+:$&23-7@$'),
+    ('GS1-128', '{B0D'),
+    ('GS1 DATABAR OMNIDIRECTIONAL', '0123456789123'),
+    ('GS1 DATABAR TRUNCATED', '0123456789123'),
+    ('GS1 DATABAR LIMITED', '0123456789123'),
+    ('GS1 DATABAR EXPANDED', '(9A{A20304+-%&06a0B'),
+    ('GS1 DATABAR EXPANDED', '(1 {C+:&23-7%'),
+    ('GS1 DATABAR EXPANDED', '(00000001234567678'),
+])
+def test_check_valid_barcode(bctype, data):
+    assert (printer.Escpos.check_barcode(bctype, data))
+
+
+@pytest.mark.parametrize("bctype,data", [
+    ('UPC-A', '01234567890123'),  # too long
+    ('UPC-A', '0123456789'),  # too short
+    ('UPC-A', '72527273-711'),  # invalid '-'
+    ('UPC-A', 'A12345678901'),  # invalid 'A'
+    ('UPC-E', '01234567890123'),  # too long
+    ('UPC-E', '012345'),  # too short
+    ('UPC-E', '72527-2'),  # invalid '-'
+    ('UPC-E', 'A123456'),  # invalid 'A'
+    ('EAN13', '0123456789'),  # too short
+    ('EAN13', 'A123456789012'),  # invalid 'A'
+    ('EAN13', '012345678901234'),  # too long
+    ('EAN8', '012345'),  # too short
+    ('EAN8', 'A123456789012'),  # invalid 'A'
+    ('EAN8', '012345678901234'),  # too long
+    ('CODE39', 'ALKJ_34'),  # invalid '_'
+    ('CODE39', 'A' * 256),  # too long
+    ('ITF', '010203040'),  # odd length
+    ('ITF', '0' * 256),  # too long
+    ('ITF', 'AB01'),  # invalid 'A'
+    ('CODABAR', '010203040'),  # no start/stop
+    ('CODABAR', '0' * 256),  # too long
+    ('CODABAR', 'AB-01F'),  # invalid 'B'
+    ('NW7', '010203040'),  # no start/stop
+    ('NW7', '0' * 256),  # too long
+    ('NW7', 'AB-01F'),  # invalid 'B'
+    ('CODE93', 'é010203040'),  # invalid 'é'
+    ('CODE93', '0' * 256),  # too long
+    ('CODE128', '010203040'),  # missing leading {
+    ('CODE128', '{D2354AA'),  # second char not between A-C
+    ('CODE128', '0' * 256),  # too long
+    ('GS1-128', '010203040'),  # missing leading {
+    ('GS1-128', '{D2354AA'),  # second char not between A-C
+    ('GS1-128', '0' * 256),  # too long
+    ('GS1 DATABAR OMNIDIRECTIONAL', '01234567891234'),  # too long
+    ('GS1 DATABAR OMNIDIRECTIONAL', '012345678912'),  # too short
+    ('GS1 DATABAR OMNIDIRECTIONAL', '012345678A1234'),  # invalid 'A'
+    ('GS1 DATABAR TRUNCATED', '01234567891234'),  # too long
+    ('GS1 DATABAR TRUNCATED', '012345678912'),  # too short
+    ('GS1 DATABAR TRUNCATED', '012345678A1234'),  # invalid 'A'
+    ('GS1 DATABAR LIMITED', '01234567891234'),  # too long
+    ('GS1 DATABAR LIMITED', '012345678912'),  # too short
+    ('GS1 DATABAR LIMITED', '012345678A1234'),  # invalid 'A'
+    ('GS1 DATABAR LIMITED', '02345678912341'),  # invalid start (should be 01)
+    ('GS1 DATABAR EXPANDED', '010203040'),  # missing leading (
+    ('GS1-128', '(' + ('0' * 256)),  # too long
+    ('GS1 DATABAR EXPANDED', '(a{D2354AA'),  # second char not between 0-9
+    ('GS1 DATABAR EXPANDED', 'IT will fail'),  # first char not '('
+])
+def test_check_invalid_barcode(bctype, data):
+    assert (not printer.Escpos.check_barcode(bctype, data))
--- a/test/test_function_dummy_clear.py
+++ b/test/test_function_dummy_clear.py
@@ -0,0 +1,8 @@
+from nose.tools import assert_raises
+from escpos.printer import Dummy
+
+def test_printer_dummy_clear():
+    printer = Dummy()
+    printer.text("Hello")
+    printer.clear()
+    assert(printer.output == b'')
--- a/test/test_function_image.py
+++ b/test/test_function_image.py
@@ -145,10 +145,8 @@ def test_large_graphics():
    assert(instance.output == b'\x1dv0\x00\x01\x00\x01\x00\xc0\x1dv0\x00\x01\x00\x01\x00\x00')


-def test_width_too_large():
-    """
-    Test printing an image that is too large in width.
-    """
+@pytest.fixture
+def dummy_with_width():
    instance = printer.Dummy()
    instance.profile.profile_data = {
        'media': {
@@ -157,8 +155,25 @@ def test_width_too_large():
            }
        }
    }
+    return instance
+
+
+def test_width_too_large(dummy_with_width):
+    """
+    Test printing an image that is too large in width.
+    """
+    instance = dummy_with_width

    with pytest.raises(ImageWidthError):
        instance.image(Image.new("RGB", (385, 200)))

-    instance.image(Image.new("RGB", (384, 200)))
+    instance.image(Image.new("RGB", (384, 200)))
+
+
+def test_center_image(dummy_with_width):
+    instance = dummy_with_width
+
+    with pytest.raises(ImageWidthError):
+        instance.image(Image.new("RGB", (385, 200)), center=True)
+
+    instance.image(Image.new("RGB", (384, 200)), center=True)
--- a/test/test_function_qr_native.py
+++ b/test/test_function_qr_native.py
@@ -13,6 +13,8 @@ from __future__ import print_function
 from __future__ import unicode_literals

 from nose.tools import raises
+import pytest
+
 import escpos.printer as printer
 from escpos.constants import QR_ECLEVEL_H, QR_MODEL_1

@@ -25,7 +27,6 @@ def test_defaults():
        b'(k\x07\x001P01234\x1d(k\x03\x001Q0'
    assert(instance.output == expected)

-
 def test_empty():
    """Test QR printing blank code"""
    instance = printer.Dummy()
@@ -81,6 +82,7 @@ def test_invalid_model():
    instance.qr("1234", native=True, model="Hello")


+@pytest.mark.skip("this test has to be debugged")
 def test_image():
    """Test QR as image"""
    instance = printer.Dummy()
@@ -99,3 +101,13 @@ def test_image_invalid_model():
    """Test unsupported QR model as image"""
    instance = printer.Dummy()
    instance.qr("1234", native=False, model=QR_MODEL_1)
+
+
+@pytest.fixture
+def instance():
+    return printer.Dummy()
+
+
+def test_center_not_implementer(instance):
+    with pytest.raises(NotImplementedError):
+        instance.qr("test", center=True, native=True)
--- a/test/test_function_qr_non-native.py
+++ b/test/test_function_qr_non-native.py
@@ -13,6 +13,7 @@ from __future__ import division
 from __future__ import print_function
 from __future__ import unicode_literals

+import pytest
 import mock

 from escpos.printer import Dummy
@@ -30,3 +31,12 @@ def test_type_of_object_passed_to_image_function(img_function):
    d.qr("LoremIpsum")
    args, kwargs = img_function.call_args
    assert isinstance(args[0], Image.Image)
+
+
+@pytest.fixture
+def instance():
+    return Dummy()
+
+
+def test_center(instance):
+    instance.qr("LoremIpsum", center=True)
--- a/test/test_function_softbarcode.py
+++ b/test/test_function_softbarcode.py
@@ -0,0 +1,16 @@
+#!/usr/bin/python
+from __future__ import absolute_import
+from __future__ import division
+from __future__ import print_function
+from __future__ import unicode_literals
+
+import escpos.printer as printer
+import pytest
+
+
+def test_soft_barcode():
+    """just execute soft_barcode
+    """
+    instance = printer.Dummy()
+    instance.soft_barcode("ean8", "1234")
+
--- a/test/test_printer_file.py
+++ b/test/test_printer_file.py
@@ -16,7 +16,7 @@ from __future__ import unicode_literals
 import six

 import pytest
-from hypothesis import given
+from hypothesis import given, settings
 from hypothesis.strategies import text

 import escpos.printer as printer
@@ -27,6 +27,8 @@ else:
    mock_open_call = '__builtin__.open'


+@pytest.mark.skip("this test is broken and has to be fixed or discarded")
+@settings(use_coverage=False)
@given(path=text())
 def test_load_file_printer(mocker, path):
    """test the loading of the file-printer"""
@@ -37,6 +39,8 @@ def test_load_file_printer(mocker, path):
    mock_open.assert_called_with(path, "wb")


+@pytest.mark.skip("this test is broken and has to be fixed or discarded")
+@settings(deadline=None, use_coverage=False)
@given(txt=text())
 def test_auto_flush(mocker, txt):
    """test auto_flush in file-printer"""
@@ -57,6 +61,8 @@ def test_auto_flush(mocker, txt):
    assert mock_device.flush.called


+@pytest.mark.skip("this test is broken and has to be fixed or discarded")
+@settings(deadline=None, use_coverage=False)
@given(txt=text())
 def test_flush_on_close(mocker, txt):
    """test flush on close in file-printer"""
--- a/test/test_raise_arbitrary_error.py
+++ b/test/test_raise_arbitrary_error.py
@@ -0,0 +1,32 @@
+#!/usr/bin/python
+"""test the raising of errors with the error module
+
+:author: `Patrick Kanzler <patrick.kanzler@fablab.fau.de>`_
+:organization: `python-escpos <https://github.com/python-escpos>`_
+:copyright: Copyright (c) 2017 `python-escpos <https://github.com/python-escpos>`_
+:license: MIT
+"""
+
+from __future__ import absolute_import
+from __future__ import division
+from __future__ import print_function
+from __future__ import unicode_literals
+
+import pytest
+import escpos
+import escpos.exceptions
+
+
+def test_raise_error_wrongly():
+    """raise error the wrong way
+
+    should reproduce https://github.com/python-escpos/python-escpos/issues/257
+    """
+    with pytest.raises(AttributeError):
+        raise escpos.Error("This should raise an AttributeError.")
+
+
+def tests_raise_error():
+    """raise error the right way"""
+    with pytest.raises(escpos.exceptions.Error):
+        raise escpos.exceptions.Error("This should raise an error.")
--- a/tox.ini
+++ b/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py27, py34, py35, docs, flake8
+envlist = py27, py34, py35, py36, py37, docs, flake8

 [testenv]
 deps = nose
@@ -7,12 +7,13 @@ deps = nose
       coverage
       scripttest
       mock
-       pytest!=3.2.0
+       pytest!=3.2.0,!=3.3.0
       pytest-cov
       pytest-mock
-       hypothesis
+       hypothesis!=3.56.9,<4
       viivakoodi
 commands = py.test --cov escpos
+passenv = ESCPOS_CAPABILITIES_PICKLE_DIR ESCPOS_CAPABILITIES_FILE CI TRAVIS TRAVIS_* APPVEYOR APPVEYOR_* CODECOV_*

 [testenv:docs]
 basepython = python
Author	SHA1	Message	Date
Patrick Kanzler	a68347ee1c	update mailmap-file	2019-06-30 17:43:20 +02:00
Brian 'Redbeard' Harrington	c40f2abe07	bug/doc: Fix invalid EAN-13 barcode in examples In the various examples and python-escpos CLI there are a number of uses of `13243546557687` as an EAN-13 example. This EAN barcode is invalid as the checksum should be `0` and not `7`. ``` $ python test_print.py Traceback (most recent call last): File "test_print.py", line 5, in <module> p.barcode('13243546557687', 'EAN13', 64, 2, '', '') File "/home/pi/fatt-display/lib/python3.7/site-packages/escpos/escpos.py", line 433, in barcode bc=bc, escpos.exceptions.BarcodeCodeError: No Barcode code was supplied (Barcode '13243546557687' not in a valid format for type 'EAN13') ``` This patch set removes `13243546557687` and replaces it with the valid number `40063813339310`. In researching the list of [assigned prefixes issued by G1][g1-prefixes] there seemed to be no "officially" defined test prefix, so this change was made to be minimally invasive using the number from the existing test cases. Resolves #350 Affects #176 [g1-prefixes]: https://www.gs1.org/standards/id-keys/company-prefix [test-code]: https://www.barcodelookup.com/4006381333931	2019-06-29 19:19:16 -07:00
Brian 'Redbeard' Harrington	fb82e5dc4a	AUTHORS: Adding Brian Redbeard to AUTHORS As per `CONTRIBUTING.rst` including a commit for Brian 'redbeard' Harrington to AUTHORS	2019-06-29 19:19:16 -07:00
Patrick Kanzler	fa140c2df5	cleanup todo page	2019-06-19 15:50:19 +02:00
Patrick Kanzler	8b3076871f	Merge pull request #346 from python-escpos/development release v3.0a6	2019-06-19 15:28:46 +02:00
Patrick Kanzler	46429b1092	update changelog	2019-06-19 14:39:52 +02:00
Patrick Kanzler	99ca096f82	Merge pull request #345 from python-escpos/setup-fix-capabilities-path improve package structure with capabilities file	2019-06-19 14:30:00 +02:00
Patrick Kanzler	2d97c0bbbd	improve package structure with capabilities file	2019-06-19 14:14:59 +02:00
Patrick Kanzler	6c6fe9bccf	Merge pull request #342 from python-escpos/108-test-on-windows-travis Add Windows and macOS configuration for Travis CI	2019-06-16 12:13:30 +02:00
Patrick Kanzler	c5e46a888d	fix allowed failures	2019-06-16 03:08:19 +02:00
Patrick Kanzler	46942820a5	update env variables	2019-06-16 03:05:42 +02:00
Patrick Kanzler	e50e295acc	add osx	2019-06-16 03:01:36 +02:00
Patrick Kanzler	2d7458fa49	activate fast_finish	2019-06-16 02:47:46 +02:00
Patrick Kanzler	a6f635c0d5	fix capabilities file	2019-06-16 02:45:40 +02:00
Patrick Kanzler	2d0f045457	add first draft of Windows conf for #108	2019-06-16 02:45:40 +02:00
Patrick Kanzler	293b8632ff	Merge pull request #341 from python-escpos/308-update-docstring-qr fix links and impl (in qr-method) in docstrings	2019-06-16 02:17:27 +02:00
Patrick Kanzler	5ff73595b6	fix links and impl (in qr-method) in docstrings fixes #308	2019-06-16 01:54:47 +02:00
Patrick Kanzler	4ecab402b8	Merge pull request #339 from python-escpos/development release v3.0a5	2019-06-16 00:31:07 +02:00
Patrick Kanzler	c56e43da84	update changelog	2019-06-16 00:17:04 +02:00
Patrick Kanzler	88af26f46e	Merge pull request #338 from alexdebiasio/development Implemented _read method of Network printer class. Solves issue #286	2019-06-16 00:01:12 +02:00
Patrick Kanzler	9dd966c2a3	update mailmap	2019-06-15 23:40:00 +02:00
Patrick Kanzler	a7d959428f	update authors	2019-06-15 22:50:50 +02:00
Alex Debiasio	8bf0e08659	Implemented _read method of Network printer class	2019-06-13 21:28:46 +02:00
Patrick Kanzler	5ac5a24b50	Toolchain update travis drop py2x (#336 ) * drop python 2 from supported languages Python 2 compatibility will not be actively revoked, but will not be worked on. * update travis config * remove flake8-test with Py2.7	2019-06-11 00:24:09 +02:00
Patrick Kanzler	63252515b5	Merge pull request #335 from python-escpos/322-doc-serial-printer-on-windows doc add example for Serial on Windows	2019-06-10 22:26:34 +02:00
Patrick Kanzler	29a546821b	doc add example for Serial on Windows fixes #322	2019-06-10 22:05:26 +02:00
Patrick Kanzler	4ddd18279f	Merge pull request #320 from ramonpoca/development Add Win32Raw printer to available printers	2019-06-07 10:11:53 +02:00
Patrick Kanzler	de761e96e3	Merge branch 'development' into development	2019-06-07 09:53:14 +02:00
Patrick Kanzler	ed7bce6932	Merge pull request #329 from akeonly/patch-1 Update README.rst : example for network printer	2019-06-05 00:05:08 +02:00
Patrick Kanzler	edd567785c	fix whitespace	2019-06-04 23:57:19 +02:00
Patrick Kanzler	f1054876da	update authors	2019-06-04 23:55:33 +02:00
Patrick Kanzler	490e0657dd	Merge branch 'development' into patch-1	2019-06-04 23:04:39 +02:00
Patrick Kanzler	b4c32b5a4a	Merge branch 'development' into development	2019-06-04 23:04:25 +02:00
Patrick Kanzler	40b30225d3	Merge pull request #330 from om26er/windows-support Enable Windows Support	2019-06-04 23:04:09 +02:00
Patrick Kanzler	19e3ec6895	Merge pull request #331 from teamorchard/use-pyyaml-safe-load Update to use pyyaml safe_load()	2019-06-04 22:45:05 +02:00
Patrick Kanzler	df539da854	Merge branch 'development' into development	2019-06-04 22:31:47 +02:00
Patrick Kanzler	4534038b39	Merge branch 'development' into patch-1	2019-06-04 22:31:33 +02:00
Patrick Kanzler	adf85f7784	Merge branch 'development' into windows-support	2019-06-04 22:31:08 +02:00
Patrick Kanzler	aaa8162967	Merge branch 'development' into use-pyyaml-safe-load	2019-06-04 22:30:47 +02:00
Patrick Kanzler	0461adc212	restrict hypothesis-version to below 4	2019-06-04 22:30:23 +02:00
Justin Vieira	91ff83e506	Update to use pyyaml safe_load(), as load() is unsafe and disabled on some systems	2019-05-29 16:43:19 -04:00
Omer Akram	29ef88f591	Better comment	2019-05-22 17:25:33 +05:00
Omer Akram	7c01a30d6c	fix a typo	2019-05-22 17:20:15 +05:00
Omer Akram	035c425581	Add author	2019-05-22 17:09:27 +05:00
Omer Akram	d20646b2a9	Make windows enablement code more intelligent	2019-05-22 17:01:13 +05:00
Omer Akram	206822ac69	Enable Windows Support	2019-05-22 16:39:26 +05:00
akeonly	dc08792e72	Update README.rst : example for network printer Add example for Network Printer	2019-05-11 18:33:33 +07:00
Ramon Poca	2886075ce9	Fix initializer mess	2018-12-31 14:24:10 +01:00
Ramon Poca	73fff6291d	Fix syntax	2018-12-31 13:57:53 +01:00
Ramon Poca	d5b9d99093	Update AUTHORS	2018-12-31 10:43:31 +01:00
Ramon Poca	18c51358aa	Add Win32Raw printer to available printers	2018-12-13 08:01:05 -08:00
Gerard Marull-Paretas	52719c0b7d	Allow arbitrary USB args	2018-11-21 22:01:13 +01:00
Patrick Kanzler	0051c876bf	Merge pull request #298 from python-escpos/development release v3.0a4	2018-05-15 23:12:17 +02:00
Patrick Kanzler	854759d312	update changelog	2018-05-15 22:48:33 +02:00
Patrick Kanzler	a0343c66af	update capabilities-data	2018-05-15 22:07:12 +02:00
Patrick Kanzler	6c94f88c24	improve platform independence (#296 ) * add os.devnull for platform independence fixes #288 * add test for soft_barcode * open devnull as binary * add version identifier to pickle	2018-05-15 01:03:07 +02:00
Patrick Kanzler	6fb23d6826	remove test from setup.py (#297 ) fixes #294	2018-05-15 00:34:43 +02:00
Patrick Kanzler	f649814091	Fix travis-builds and tests in general (#295 ) * add explicit location of capabilities.json for travis * pass on env variables in tox builds * drop support for python 3.3 and remove python3.3 from supported versions list	2018-05-14 18:06:31 +02:00
Patrick Kanzler	47b4d41b28	use package for tempdir cherry-picked from `8494cca526` in #274	2018-05-13 18:52:39 +02:00
Patrick Kanzler	599f4f3ca5	add new authors	2018-05-13 18:44:47 +02:00
primax79	d085e5c467	parameter for implementation of nonnative qrcode (#289 )	2018-05-13 18:42:41 +02:00
kennedy	b418302311	Modified submodule to always pull from master branch (#283 )	2018-05-13 18:42:07 +02:00
Patrick Kanzler	f6acb72bbe	Merge branch 'fix-travis-builds' into development	2018-05-13 18:40:57 +02:00
Patrick Kanzler	0c9856c1f6	disable QR test for image	2018-05-13 18:26:48 +02:00
Patrick Kanzler	a748563395	blacklist hypothesis version	2018-05-13 18:04:48 +02:00
Patrick Kanzler	b84e280efb	disable broken tests	2018-05-13 17:32:52 +02:00
Thijs Triemstra	4390dc4a9c	fix is_online() (#282 ) * fix is_online * fix sphinx formatting * reword	2018-05-02 09:25:04 +02:00
Thijs Triemstra	6e09fd1e97	fix typo	2018-04-26 07:22:37 +02:00
Thijs Triemstra	100c6b5e89	fix typo (#279 )	2018-02-07 22:17:18 +01:00
Christoph Heuel	26d72a69f0	Feature/clear content in dummy printer (#271 ) Add Function to Dummy Printer for Clearing Buffer If you are using the dummy printer, you may want to use the printer again after sending the output to a physical printer. This method empties the list of the output buffer.	2017-12-04 00:13:28 +01:00
Patrick Kanzler	01e28bbcf6	ammend blacklisting from `cd1bcb57b4` the last comment was a bit rushed and did not properly blacklist both bad versions of pytest	2017-12-03 23:49:46 +01:00
Patrick Kanzler	2a7e2a6a36	blacklist pytest 3.3.0 see pytest-dev/pytest#2957	2017-12-03 23:43:23 +01:00
reck	3c3dab95f5	raise exception when TypeError occurs in cashdraw (#268 )	2017-12-03 23:21:29 +01:00
Patrick Kanzler	d1e7052fa1	Merge pull request #266 from python-escpos/development release v3.0a3	2017-10-08 22:45:54 +02:00
Patrick Kanzler	10e1dfe1d1	update changelog	2017-10-08 22:26:55 +02:00
Patrick Kanzler	cd1bcb57b4	remove bugtrack_url this is not supported by setuptools	2017-10-08 22:12:53 +02:00
Patrick Kanzler	d6d12f99d4	improve test - tests raising of error #257	2017-10-08 21:53:36 +02:00
Patrick Kanzler	128221363f	reproduce #257	2017-10-08 21:53:36 +02:00
Patrick Kanzler	6b0b1371e5	fix layout in File-printer-section	2017-10-08 21:31:45 +02:00
Patrick Kanzler	44f01a212b	fix docs failing due to pickle protocol in mixed env When executing a tox-run a pickle file will be created. If the docs are built after the py3 task, it will fail due to incompatible pickle-protocols. See https://stackoverflow.com/a/25843743/4244236 for reference.	2017-10-08 21:08:13 +02:00
Lucy Linder	456f5b7aa6	Feature/check barcodes (#255 ) * add a method to check barcode code format ensure that the code to print is compatible with the ESC/POS formats and also automatically check this format before printing (barcode() method). * rewrite test using pytest's parametrize functionality * add test for the 'check' argument * update authors list	2017-10-08 20:05:18 +02:00
Patrick Kanzler	d78a6f1699	completely fix tests The feature use_coverage of hypothesis caused the failing tests, because the printer_file_test is sensitive to the coverage analysis of hypothesis. Fixed by disabling use_coverage for the crashing tests	2017-09-27 10:38:42 +02:00
Patrick Kanzler	5e784c060a	fix tests failing (for now) hypothesis introduced a regression in 3.29.0 (or at least changed behaviour). Until I have found the problem I will pin it to the last working version. Also two tests should be prevented from failing when they are slow.	2017-09-27 10:29:19 +02:00
Patrick Kanzler	1439b14686	tell sort to ignore case	2017-08-31 13:43:07 +02:00
Romain Porte	b648cfd67f	First attempt at centering images and QRs (#250 ) This was tested on ZJ-5890 with success. By default centering is deactivated for backward compatibility. Trying to center a QR code in native mode will raise an exception as we do not know ATM if the native rendering is centered by default or not. * Added basic tests for center feature * Check image size before centering	2017-08-31 09:25:35 +02:00
Sergio	50c627fbb0	Pickling capabilities for faster start up times. (#252 ) On a RaspberryPi it's taking 10 seconds to simply run: import escpos.printer This change creates a pickle file that will load 20x faster. The rationale is that the capabilities.json file doesn't change too often. Also changed some imports for PEP8.	2017-08-31 09:07:26 +02:00
Sergio Pulgarin	99034d0575	Fixed outdated example file: should be font 'b' not 'B' Updated AUTHORS using script.	2017-08-31 08:38:32 +02:00
Patrick Kanzler	19663ec574	fix cut function in example	2017-08-10 21:54:52 +02:00
Patrick Kanzler	281eea125f	fix abstract read-function read does not need msg-parameter	2017-08-10 21:51:51 +02:00
Patrick Kanzler	5bed0bfbb4	fix name of pyyaml for PyPi	2017-08-09 10:41:25 +02:00
Patrick Kanzler	f12470d3cd	update contributing	2017-08-08 13:37:30 +02:00
Patrick Kanzler	fb0e4c28ba	update README	2017-08-08 13:30:16 +02:00