setop/sqlite-parquet-vtable
1
0
Fork 0
mirror of https://github.com/cldellow/sqlite-parquet-vtable.git synced 2025-09-08 22:24:56 +00:00
Code Releases Activity

Make rowid start from 1, not 0

Browse Source 
Unclear whether this is strictly required, but I'm going to start using
SQLite as an oracle, and it'll be simpler if our rowids match theirs.
This commit is contained in:
Colin Dellow
2018-03-18 17:03:46 -04:00
parent d430a45e41
commit e2af2a07a4
28 changed files with 405 additions and 405 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
parquet/parquet_cursor.cc
View File

@@ -682,7 +682,7 @@ int ParquetCursor::getRowId() {
}
bool ParquetCursor::eof() {
return rowId >= numRows;
return rowId > numRows;
}
void ParquetCursor::ensureColumn(int col) {
@@ -937,7 +937,7 @@ void ParquetCursor::close() {
void ParquetCursor::reset(std::vector<Constraint> constraints) {
close();
this->constraints = constraints;
rowId = -1;
rowId = 0;
// TODO: consider having a long lived handle in ParquetTable that can be borrowed
// without incurring the cost of opening the file from scratch twice
reader = parquet::ParquetFileReader::OpenFile(
@@ -948,7 +948,7 @@ void ParquetCursor::reset(std::vector<Constraint> constraints) {
rowGroupId = -1;
rowGroupSize = 0;
rowGroupStartRowId = -1;
rowGroupStartRowId = 0;
// TODO: handle the case where rowgroups have disjoint schemas?
// TODO: or at least, fail fast if detected
rowsLeftInRowGroup = 0;